Deprecate NDefOps and NIso #18668
Merged
Deprecate NDefOps and NIso #18668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coqbot-app
bot
added
the
needs: full CI
Villetaneuse
added a commit
to Villetaneuse/coq
that referenced
this pull request
Feb 12, 2024
|
@coqbot run full ci |
coqbot-app
bot
removed
the
needs: full CI
|
Indeed, maybe more results for logicians than for a stdlib. |
Villetaneuse
added
kind: cleanup
proux01
reviewed
Feb 13, 2024
coqbot-app
bot
added
the
needs: full CI
Villetaneuse
force-pushed
the
depr_NDefOps_NIso
branch
from
fe09144
to
912e73b
Compare
These files are not used in the stdlib, it's unlikely they are very useful to anyone. - `Numbers.Natural.Abstract.NDefOps` defines some operations on an abstract Natural domain; the operations should be defined in the corresponding implementations instead. - `Numbers.Natural.Abstract.NIso` studies isomorphisms between models of NAxioms, this is very rarely (if at all) used.
proux01
force-pushed
the
depr_NDefOps_NIso
branch
from
912e73b
to
4f81d36
Compare
|
Apparently, the refman compilation failure was due to the faulty indentation of the changelog of #18564 (cc @andres-erbsen FYI) but only showed up now, when adding something below in the same item list. |
|
@coqbot merge now |
|
@proux01: You cannot merge this PR because:
|
proux01
removed
the
needs: full CI
|
@coqbot merge now |
|
@proux01: You can't merge the PR because it hasn't been approved yet. |
proux01
approved these changes
Feb 14, 2024
|
@coqbot merge now |
Thank you very much! |
|
@Villetaneuse: You cannot merge this PR because:
|
louiseddp
pushed a commit
to louiseddp/coq
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files are not used in the stdlib, it's unlikely they are very useful to anyone.
Numbers.Natural.Abstract.NDefOpsdefines some operations on an abstract Natural domain; the operations should be defined in the corresponding implementations instead.Numbers.Natural.Abstract.NIsostudies isomorphisms between models of NAxioms, this is very rarely (if at all) used.