New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "Found no matching notation to enable or disable." a warning #18670
Conversation
instead of an error
The PR is nice for an "interactive"/"primary" use of |
No, my comment is wrong. Let me think again. |
I updated my comment. I would simply ignore the absence of a notation when deactivation comes from an Here is another variant of the Zulip example, showing a desynchronisation of imports: (* comp.v *)
Definition comp {A B C} (f : B -> C) (g: A -> B) : A -> C :=
fun a => f (g a).
Notation " g '\o' f " := (comp g f) (at level 40, left associativity).
Check ((@id nat) \o (@id nat)). (* comp_utf.v *)
Require Import NotationTest.comp.
Disable Notation "\o".
Notation " g '∘' f " := (comp g f) (at level 40, left associativity). (* comp_utf2.v *)
Require Import NotationTest.comp_utf.
Enable Notation "\o". and (* user.v*)
Require Import comp.
Require comp_utf.
Locate "\o". (* Notation " g '\o' f " := (comp g f) (default interpretation) *)
Require Import comp_utf2. (* Error: Found no matching notation to enable or disable *) |
@herbelin do you want to merge this or should I close it? (I unfortunately do'nt have time to do anything better in the foreseable future) |
It brings something so I'm leaning towards merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More convenient than an error.
@coqbot merge now |
@herbelin: You cannot merge this PR because:
|
@coqbot run full ci |
OK @coqbot merge now |
Reviewed-by: proux01 Co-authored-by: proux01 <proux01@users.noreply.github.com>
…disable." a warning
(cherry picked from commit 01d0d0c)
instead of an error
Updated documented syntax by runningmake doc_gram_rsts
.