Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for timeout tactic #18728

Merged
merged 1 commit into from Mar 13, 2024
Merged

Conversation

SkySkimmer
Copy link
Contributor

  • there is an implicit once

  • windows has timeout since 81c8acb AFAICT

- there is an implicit `once`

- windows has timeout since 81c8acb AFAICT
@SkySkimmer SkySkimmer requested a review from a team as a code owner February 28, 2024 16:15
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Feb 28, 2024
@ejgallego
Copy link
Member

Not sure windows timeout implementation was working?

@SkySkimmer SkySkimmer added the kind: documentation Additions or improvement to documentation. label Mar 1, 2024
@SkySkimmer SkySkimmer added this to the 8.20+rc1 milestone Mar 1, 2024
@SkySkimmer SkySkimmer removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Mar 1, 2024
@SkySkimmer
Copy link
Contributor Author

Maybe it used to be broken but I think it's supposed to work now.

@proux01 proux01 self-assigned this Mar 13, 2024
@proux01
Copy link
Contributor

proux01 commented Mar 13, 2024

@coqbot merge now

@coqbot-app coqbot-app bot merged commit c20c57b into coq:master Mar 13, 2024
6 checks passed
@SkySkimmer SkySkimmer deleted the update-timeout-doc branch March 13, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: documentation Additions or improvement to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants