Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ltac2 add APIs to customize pretype flags #18765

Merged
merged 1 commit into from Apr 1, 2024

Conversation

SkySkimmer
Copy link
Contributor

Deprecate the open_constr_flags definition to make it clear when using typeclasses unlike open_constr:().

The deprecated open_constr_flags is also changed as it stops evar normalizing.

@SkySkimmer SkySkimmer added needs: changelog entry This should be documented in doc/changelog. part: ltac2 Issues and PRs related to the (in development) Ltac2 tactic langauge. request: full CI Use this label when you want your next push to trigger a full CI. labels Mar 8, 2024
@SkySkimmer SkySkimmer requested a review from a team as a code owner March 8, 2024 14:57
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Mar 8, 2024
Deprecate the `open_constr_flags` definition to make it clear when
using typeclasses unlike `open_constr:()`.

The deprecated `open_constr_flags` is also changed as it stops
evar normalizing.
@SkySkimmer SkySkimmer removed the needs: changelog entry This should be documented in doc/changelog. label Mar 14, 2024
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Mar 14, 2024
@ppedrot ppedrot added this to the 8.20+rc1 milestone Mar 25, 2024
@ppedrot ppedrot self-assigned this Mar 25, 2024
@ppedrot
Copy link
Member

ppedrot commented Mar 25, 2024

@coqbot run full ci

@coqbot-app coqbot-app bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Mar 25, 2024
@ppedrot
Copy link
Member

ppedrot commented Apr 1, 2024

@coqbot merge now

Copy link
Contributor

coqbot-app bot commented Apr 1, 2024

@ppedrot: You cannot merge this PR because:

  • There is no kind: label.

@ppedrot ppedrot added the kind: feature New user-facing feature request or implementation. label Apr 1, 2024
@ppedrot
Copy link
Member

ppedrot commented Apr 1, 2024

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 8b36f18 into coq:master Apr 1, 2024
6 checks passed
@SkySkimmer SkySkimmer deleted the ltac2-pretype-flags branch April 2, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature New user-facing feature request or implementation. part: ltac2 Issues and PRs related to the (in development) Ltac2 tactic langauge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants