[8.20] Update compat infrastructure prior to branching #19026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proux01
added
kind: cleanup
coqbot-app
bot
removed
the
request: full CI
JasonGross
requested changes
May 15, 2024
proux01
added
the
request: full CI
proux01
force-pushed
the
update-compat-release
branch
from
db2b87d
to
af94514
Compare
coqbot-app
bot
removed
the
request: full CI
|
@silene (8.20 coRM) this is ready @JasonGross please update your review status |
|
I don't understand why you are removing the file |
|
The script removes it because then it would become identical to |
JasonGross
approved these changes
May 17, 2024
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a PR on master, call dev/tools/update-compat.py with the --release flag; this sets up Coq to support three -compat flag arguments including the upcoming one (instead of four). To ensure that CI passes, you will have to decide what to do about all test-suite files that mention -compat U.U or Coq.Compat.CoqUU (which is no longer valid, since we only keep compatibility against the two previous versions), and you may have to ping maintainers of projects that are still relying on the old compatibility flag so that they fix this.
(c.f. #18882 )