Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use at least 6 Xs in mktemp filename templates #7470

Merged
merged 1 commit into from May 11, 2018
Merged

use at least 6 Xs in mktemp filename templates #7470

merged 1 commit into from May 11, 2018
+4 −4

Conversation

pesco
Copy link
Contributor

@pesco pesco commented May 9, 2018

OpenBSD mktemp fails with an error otherwise.

Kind: bug fix

Fixes #7469

@pesco
use at least 6 Xs in mktemp filename templates
595c725 
OpenBSD mktemp fails with an error otherwise.
@pesco pesco requested a review from SkySkimmer as a code owner May 9, 2018 16:54
SkySkimmer
SkySkimmer approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@SkySkimmer SkySkimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XXX_XXX

@SkySkimmer SkySkimmer self-assigned this May 9, 2018
@SkySkimmer SkySkimmer added kind: fix This fixes a bug or incorrect documentation. kind: infrastructure CI, build tools, development tools. labels May 9, 2018
@SkySkimmer SkySkimmer added this to the 8.8.1 milestone May 9, 2018
@Zimmi48 Zimmi48 added this to Request 8.8 inclusion in Coq 8.8 May 10, 2018
SkySkimmer added a commit to SkySkimmer/coq that referenced this pull request May 11, 2018
@SkySkimmer
Merge PR coq#7470: use at least 6 Xs in mktemp filename templates
7a6cac1
@SkySkimmer SkySkimmer merged commit 595c725 into coq:master May 11, 2018
Coq 8.8 automation moved this from Request 8.8 inclusion to Waiting to be backported May 11, 2018
Zimmi48 added a commit to Zimmi48/coq that referenced this pull request May 17, 2018
@Zimmi48
Backport PR coq#7470: use at least 6 Xs in mktemp filename templates
231cd36
@Zimmi48 Zimmi48 moved this from Request 8.8 inclusion to Waiting for CI in Coq 8.8 May 17, 2018
@Zimmi48 Zimmi48 moved this from Waiting for CI to Shipped in 8.8.1 in Coq 8.8 May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkySkimmer SkySkimmer SkySkimmer approved these changes

Assignees

@SkySkimmer SkySkimmer

Labels
kind: fix This fixes a bug or incorrect documentation. kind: infrastructure CI, build tools, development tools.
Projects
No open projects
Coq 8.8
  
Shipped in 8.8.1
Milestone
8.8.1
Development

Successfully merging this pull request may close these issues.

mktemp calls fail on OpenBSD due to insufficient X's
2 participants
@pesco @SkySkimmer