Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ssrmatching] update license banner (fix #9281) #9282

Merged
merged 1 commit into from Jan 8, 2019

Conversation

gares
Copy link
Member

@gares gares commented Dec 25, 2018

This commit fixes a leftover of the merge of ssrmatching where
the .ml code received the appropriate banner, while the .v and
.mli di dnot.

This commit fixes a leftover of the merge of ssrmatching where
the .ml code received the appropriate banner, while the .v and
.mli di dnot.
@gares gares added the kind: fix This fixes a bug or incorrect documentation. label Dec 25, 2018
@gares gares added this to the 8.10+beta1 milestone Dec 25, 2018
@gares gares requested a review from a team as a code owner December 25, 2018 08:00
@bbarenblat
Copy link
Contributor

Is there any chance somebody could look at this in the next week or two? If this gets merged, it’s going to be a lot easier to include SSReflect in the upcoming Debian 10 release. Without it, the next Debian might ship without SSReflect (and, by extension, mathcomp).

@andres-erbsen
Copy link
Contributor

Please also backport this to 8.9. As a comment-only change, it should be safe, and then if 8.9 manages to get released in the next couple of weeks it can still go into Debian 10 as well.

@bbarenblat
Copy link
Contributor

I’m happy to do the backport if that helps speed things along.

@Zimmi48 Zimmi48 modified the milestones: 8.10+beta1, 8.9.0 Jan 7, 2019
@gares
Copy link
Member Author

gares commented Jan 7, 2019

@maximedenes do you mind handling this PR?

@maximedenes
Copy link
Member

I'm not qualified but happy to merge.

maximedenes added a commit to maximedenes/coq that referenced this pull request Jan 8, 2019
@coqbot coqbot added this to Request inclusion in 8.9.0 in Coq 8.9 Jan 8, 2019
@maximedenes maximedenes merged commit a92e4fb into coq:master Jan 8, 2019
@coqbot coqbot moved this from Request inclusion in 8.9.0 to Shipped in 8.9.0 in Coq 8.9 Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: fix This fixes a bug or incorrect documentation.
Projects
No open projects
Coq 8.9
  
Shipped in 8.9.0
Development

Successfully merging this pull request may close these issues.

None yet

5 participants