New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dune] Simple rule to generate Stdlib's documentation. #9649
Conversation
59e5f37
to
63bc1ad
Compare
9a66ceb
to
a44bd0a
Compare
a44bd0a
to
c63c8e8
Compare
Compcert failed due to AbsInt/CompCert#275 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why bedrock failed
Linter error is spurious (#9653) and in the per-commit part, we can ignore it.
Do we merge without the .glob dependencies?
Nope, let me fix that indeed, and rebase on top of #9648 |
I'll let @Zimmi48 as dune secondary assign. |
Rebased, but I am not sure how to test the deploy job (@vbgl ?) |
c63c8e8
to
4fd4758
Compare
To test deploy jobs, I’ve manually started a CI pipeline with the appropriate credentials. I can do it for you if you think its necessary. |
Yup but that would overwrite the main Coq repos, right? I guess I'll deploy to my own repos, and make the clone target a variable then. |
It will not overwrite, but put you artifact in a separate directory (named as your branch: |
Ah Ok, cool then! |
I'd appreciate indeed if you can push a build to see whether that works. |
Pipeline started. Result should appear in a few hours there: https://coq.github.io/doc/dune+coqdoc |
Muchas gracias @vbgl |
Will wait for the deploy build to finish before the rebase. |
There is also a problem with the artifacts (which should in principle make the deploy job fail): |
4fd4758
to
2370031
Compare
Well-spotted @Zimmi48 ahhh; indeed @SkySkimmer was right, I've added an extra CI job which should help consistency. Fixed version uploaded, deploy job needs relaunch. |
2370031
to
7ba806b
Compare
Pipeline launched for 7ba806b. |
Ideally this will be handled by Dune's native library support, but this could be useful for the likes of coq#9648. I am not sure what should be done w.r.t. style files.
7ba806b
to
07ce258
Compare
The deploy jobs went through (also for the last update). There are some issues with the documentation of the stdlib. E.g., at https://coq.github.io/doc/dune+coqdoc/stdlib/, in the “navigation” part, there is a dead link to |
It seems to work well here @vbgl , are you sure you were not looking to an older build [which had this problem] So far, the docs looks pretty good to me. |
My bad. It looks good indeed. |
Reviewed-by: SkySkimmer Reviewed-by: Zimmi48 Ack-by: rgrinberg
Thanks to all for the help! |
Ideally this will be handled by Dune's native library support, but
this could be useful for the likes of #9648.
I am not sure what should be done w.r.t. style files.