Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CoqIDE progress bar. #9807

Merged
merged 2 commits into from Mar 27, 2019
Merged

Fix CoqIDE progress bar. #9807

merged 2 commits into from Mar 27, 2019

Conversation

ppedrot
Copy link
Member

@ppedrot ppedrot commented Mar 20, 2019

This brings back the progress bar feature of CoqIDE after #9279.

@ppedrot ppedrot added the kind: fix This fixes a bug or incorrect documentation. label Mar 20, 2019
@ppedrot ppedrot added this to the 8.10+beta1 milestone Mar 20, 2019
@ppedrot ppedrot added the part: CoqIDE Issues and PRs related to CoqIDE or other IDE features of coq. label Mar 20, 2019
@vbgl
Copy link
Contributor

vbgl commented Mar 20, 2019

The nix job failing on CI is probably due to cairo being there at version 0.5. I’m working on this.

@ejgallego
Copy link
Member

The nix job failing on CI is probably due to cairo being there at version 0.5. I’m working on this.

Yup Cairo support needs both the latest ocaml-cairo and lablgtk3 beta.

@vbgl
Copy link
Contributor

vbgl commented Mar 20, 2019

Should be fixed after NixOS/nixpkgs#57965 is merged.

@ppedrot ppedrot requested a review from a team as a code owner March 27, 2019 10:28
@vbgl
Copy link
Contributor

vbgl commented Mar 27, 2019

I’ve just updated the reference to nixpkgs. CI seems happy now.

@vbgl
Copy link
Contributor

vbgl commented Mar 27, 2019

Ping secondary code owners @gares @herbelin

@gares gares self-assigned this Mar 27, 2019
@gares
Copy link
Member

gares commented Mar 27, 2019

thanks!

@gares gares merged commit d8e6495 into coq:master Mar 27, 2019
gares added a commit that referenced this pull request Mar 27, 2019
@gares
Merge PR #9807: Fix CoqIDE progress bar.
738521c 
Reviewed-by: Zimmi48
@ppedrot ppedrot deleted the ide-fix-progress-bar branch March 27, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zimmi48 Zimmi48 Zimmi48 approved these changes

Assignees

@gares gares

Labels
kind: fix This fixes a bug or incorrect documentation. part: CoqIDE Issues and PRs related to CoqIDE or other IDE features of coq.
Projects
None yet
Milestone
8.10+beta1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ppedrot @vbgl @ejgallego @gares @Zimmi48