New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompCert 3.14 #3029
CompCert 3.14 #3029
Conversation
install: [make "install"] | ||
dev-repo: "git+https://github.com/AbsInt/CompCert.git" | ||
url { | ||
src: "https://github.com/AbsInt/CompCert/archive/v3.14.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standard advice we give on archives that live on GitHub. Since the archives are no longer held stable over time, we recommend uploading an archive manually into the release, as is done for Coq: https://github.com/coq/coq/releases/download/V8.19.1/coq-8.19.1.tar.gz
For background, see https://github.blog/2023-02-21-update-on-the-future-stability-of-source-code-archives-and-hashes/
GitHub will hold the source downloads byte-for-byte stable for no less than a year from today (February 21, 2023). This covers both tarball (.tar.gz) and zipball (.zip) formats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out to me. I don't think we do that for OCaml source releases, which would be a much bigger annoyance than CompCert if they were to change in time... Let me check with the OCaml core dev team.
url { | ||
src: "https://github.com/AbsInt/CompCert/archive/v3.14.tar.gz" | ||
checksum: | ||
"sha512=cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"sha512=cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e" | |
"sha512=5b3bdba47989f99340fc3e53e76c4994104cb884af123a09e867f5e66a3fc827e5290879a786dbdcda2fa5419210ffc151b5d6e9b4a459e29ca289fd5c12b19a" |
CI said there was a checksum issue. @xavierleroy in the interest of making this available to users quickly, how about we merge this now even with the "unstable" archive? I'd be happy to update the package definition with a new URL if you comment on this PR at some later point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the wrong checksum, I tried to use curl
cleverly and obviously failed.
OK for merging this package in its current state and doing "the right thing" later.
I did get interesting feedback from the OCaml core dev team about this issue. There are pros to uploading a home-built archive, but also some cons, e.g. it may not correspond to the Git repository...
Released a few days ago. See https://github.com/AbsInt/CompCert/releases/tag/v3.14 for a list of changes.