Enforce phonemizer definition for synthesis #1441
Conversation
WeberJulian
commented
Mar 24, 2022
WeberJulian
commented
- Set the phonemizer picked at train time in the config
- Enforce phonemizer definition for synthesis
|
Can we unittest it not to miss it the next time? |
| @@ -34,8 +34,8 @@ | |||
|
|
|||
| # train the model for one epoch | |||
| command_train = ( | |||
| f"CUDA_VISIBLE_DEVICES='{get_device_id()}' python TTS/bin/train_tts.py --config_path file://{config_path} " | |||
There was a problem hiding this comment.
when you remove file:// then it is not different than a regular training test. Am I wrong?
There was a problem hiding this comment.
On my system the path was incorrectly parsed, it created a folder file: in my TTS directory.
I'm not sure what's the expected behavior, I just thought it was a bug.
I can reverse the commit, it was just to trigger the CI since it was bugged yesterday.
There was a problem hiding this comment.
Because we removed fsspec saving in the trainer since it broke the checkpoints uploaded to the cloud. I think we can even remove the test completely
You mean testing that synthesis doesn't work if phonemizer is undifined? |
More like checking the config.json if characters are passed as needed. |
