New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug related to yourtts speaker embeddings issue #2234
Conversation
I reversed changes made in base_tts.py so we can merge this typo fix for now |
I fixed the issue with the following:
In addition, I added the speaker encoder model and config paths on the YourTTS recipe as default to easily do zero-shot inference. In this way the user will not need to change the config.json manually to set these paths and any model trained with the YourTTS will be able to do inference using "--speaker_idx" and "--speaker_wav". |
@Edresson is it possible to add a test case to prevent that to happen again? |
I don't think so. The only long-term test that I can see is on coqpit side. We should raise an error if the type of argument is different. Currently, it overrides the value by None and it is hard to debug it. |
@erogol Everything looks ok to me. Could you merge it, pleaase? |
I am definitely getting this error when running the yourtts train recipe from a restore path, the code is exact to the recipie:-
The rcepie code + my small change of restore path:
|
@iamkhalidbashir error from this PR? |
Yes I took recipie from this PR. |
But in the pr |
Yes, I did use the latest. @Edresson Doesn't seem to reproduce this on his end, not sure if it's related to my python version. I will debug where the issue lies. |
How do i make sure i dont get the error? |
I do this
then the error disappears.
|
thank you so much! That worked. Also how do i change the number of epochs, it seems to be 1000 by default |
Jus add a property named epoch=3 for example
On Tue, 3 Jan 2023 at 2:24 PM Aditya Srinivas Menon < ***@***.***> wrote:
thank you so much! That worked. Also how do i change the number of epochs,
it seems to be 1000 by default
—
Reply to this email directly, view it on GitHub
<#2234 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGS5WWYZ245232JMKET7YTDWQPV6JANCNFSM6AAAAAATGRXCI4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Mr. Bashir,*
*CEO, AMOXT Pvt. Ltd*
|
Fixes: #2236