Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note fields to license documents and improve handling of tree da… #330

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

fondrenlibrary
Copy link
Contributor

@fondrenlibrary fondrenlibrary commented Nov 13, 2017

This PR does two things:

  1. Add note fields to licensing documents. This new feature needs to run licensing/install/protected/001-330.sql
  2. improve handling of tree structured licensing document records.

Demo can be seen at: http://testbed4Coral.library.rice.edu with username/password available upon request.
Two screensnap shots showing the features introduced by PR #330
image

image

@fondrenlibrary fondrenlibrary changed the title Add note fields to licensing documents and improve handle of tree da… Add note fields to licensing documents and improve handling of tree da… Nov 14, 2017
…he Parent dropdown of the Document Upload form
@fondrenlibrary fondrenlibrary changed the title Add note fields to licensing documents and improve handling of tree da… Add note fields to license documents and improve handling of tree da… Nov 15, 2017
@fondrenlibrary
Copy link
Contributor Author

fondrenlibrary commented Nov 16, 2017

Tested and substituted jquery 2.2.4 and jquery-migrate 1.4 for jquery 1.10.2 and jquery-migrate-1.2 which were ever used to replace the original jquery 1.4.4 plugin of the License module. Please note, the this PR actually the used treegrid plugin ) doesn't work with jquery 1.4.4 and lower

@PaulPoulain PaulPoulain added the enhancement This is an enhancement (not a bug) label Dec 12, 2017
@fondrenlibrary fondrenlibrary added this to Parking lot (issues/pull requests moved to a future release or canceled due to various reasons) in CORAL 3.0 Release Mar 22, 2018
@fondrenlibrary fondrenlibrary removed this from Parking lot (issues/pull requests moved to a future release or canceled due to various reasons) in CORAL 3.0 Release Mar 22, 2018
@jeffnm
Copy link
Member

jeffnm commented Apr 29, 2019

This PR is a bit out of date. If you'd like to update it, could you separate jquery changes into their own PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement (not a bug)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants