Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PIG (Public Interface Generator) addon into main Coral repository #467

Merged
merged 2 commits into from Nov 28, 2018

Conversation

veggiematts
Copy link
Contributor

@veggiematts veggiematts commented Aug 22, 2018

This PR integrates the PIG addon to the main Coral codebase.
PIG is originally available here: https://github.com/TAMULib/CORAL_Addons/tree/master/resources/pig

No database update is needed.

We may want to add a way to enable/disable PIG though.

@veggiematts veggiematts added the enhancement This is an enhancement (not a bug) label Aug 22, 2018
@veggiematts
Copy link
Contributor Author

Once the patch applied, PIG is available at this address: /resources/pig.php

@LibClaire
Copy link

I applied the patch and was able to navigate to /resources/pig.php, view resources and link out to them.

@jeffnm jeffnm added this to In progress in CORAL 3.0.1 Patch via automation Oct 24, 2018
@jeffnm
Copy link
Member

jeffnm commented Oct 24, 2018

I also was able to access the PIG without authentication as expected.

I agree we should definitely have a toggle for PIG and I think it should be off by default.

I'm not sure if we should add PIG to the code base without that option since it's always been an Add-on and not a default functionality in the past. Let's get some more feedback on this.

@xsong9
Copy link
Contributor

xsong9 commented Oct 24, 2018

I would like to keep it as an add-on, not a default functionality, simply because not all users would use it. I also like the idea of having a toggle to make the switch easier for users to use.

@veggiematts
Copy link
Contributor Author

Whatever's decided, here's a patch providing a configuration entry for PIG, disabled by default.

My opinion on this: we're currently trying to make things more integrated (we've already merged the git repositories in one, we were talking about merging the databases in one, etc.) and easier to install.
I think it wouldn't hurt to provide PIG available out of the box, without the hassle of installing it from an external repository.
That being said, I totally agree with the fact that it should be disabled by default.

@poacherone
Copy link
Collaborator

I agree that it makes sense to add PIG to the codebase, but have it configurable and off as default.

@jeffnm
Copy link
Member

jeffnm commented Oct 25, 2018

I think your on/off option is good enough for an initial inclusion. I agree that it's better to keep all the CORAL code in one repository, and give easy options to turn things on or off.

Is there a reason you called the configuration entry "pIG" rather than "PIG"? You were consistent, so it works, but I'm curious.

@veggiematts
Copy link
Contributor Author

Is there a reason you called the configuration entry "pIG" rather than "PIG"? You were consistent, so it works, but I'm curious.

Yep, one good reason: it didn't work with a capital "P"

@veggiematts
Copy link
Contributor Author

Can we merge this?

@veggiematts veggiematts closed this Nov 8, 2018
CORAL 3.0.1 Patch automation moved this from In progress to Done Nov 8, 2018
@veggiematts veggiematts reopened this Nov 8, 2018
CORAL 3.0.1 Patch automation moved this from Done to In progress Nov 8, 2018
@jeffnm jeffnm merged commit 408aba2 into coral-erm:development Nov 28, 2018
CORAL 3.0.1 Patch automation moved this from In progress to Done Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement (not a bug)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants