New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PIG (Public Interface Generator) addon into main Coral repository #467
Conversation
aa4e59f
to
4d71840
Compare
Once the patch applied, PIG is available at this address: /resources/pig.php |
I applied the patch and was able to navigate to /resources/pig.php, view resources and link out to them. |
I also was able to access the PIG without authentication as expected. I agree we should definitely have a toggle for PIG and I think it should be off by default. I'm not sure if we should add PIG to the code base without that option since it's always been an Add-on and not a default functionality in the past. Let's get some more feedback on this. |
I would like to keep it as an add-on, not a default functionality, simply because not all users would use it. I also like the idea of having a toggle to make the switch easier for users to use. |
Whatever's decided, here's a patch providing a configuration entry for PIG, disabled by default. My opinion on this: we're currently trying to make things more integrated (we've already merged the git repositories in one, we were talking about merging the databases in one, etc.) and easier to install. |
I agree that it makes sense to add PIG to the codebase, but have it configurable and off as default. |
I think your on/off option is good enough for an initial inclusion. I agree that it's better to keep all the CORAL code in one repository, and give easy options to turn things on or off. Is there a reason you called the configuration entry "pIG" rather than "PIG"? You were consistent, so it works, but I'm curious. |
Yep, one good reason: it didn't work with a capital "P" |
Can we merge this? |
This PR integrates the PIG addon to the main Coral codebase.
PIG is originally available here: https://github.com/TAMULib/CORAL_Addons/tree/master/resources/pig
No database update is needed.
We may want to add a way to enable/disable PIG though.