-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 411: Pricing formulas #522
base: development
Are you sure you want to change the base?
Issue 411: Pricing formulas #522
Conversation
- Add/edit/delete formulas in admin
- Use formulas in costs
- Use cost_to_integer and integer_to_cost
- Fix line removal
- Improve UI, add translations
- Prevent formulas with non-mathematical expressions from being executed
- Display formula with values once saved
- Fix form width
- use number_format to have consistent number format
- Fix formula regex
- Remove log message
- Zeroing unprovided values
- Fix form for proper display on small resolutions
- Fix use of simple and double quotes in pricing formula field names
- use number_format to have consistent number format (follow-up)
The Steering Committee reviewed the request and a couple of questions came up regarding the potential use. We'd love to discuss this with you at a future Steering Committee meeting. |
Hi, Sure, we'll try to be there at the next Coral SC meeting to answer your questions. |
Any specific questions, by the way ? |
CORAL Steering Committee approved the PR. |
- Disable pricing formulas in acquisitions when no princing formulas are defined - Add a sample formula when adding or editing a formula
Here are the requested modifications:
Also, here is the paragraph to add in the documentation: To add a pricing formula, go to the administration page in the resources module and click on the "Pricing Formula" tab. Here is another example: Name: Multiple prices with two different discounts |
Hi ! Is anything still preventing this PR from being merged ? |
See Issue #411 for description.
Test plan:
resources/install/protected/3.0.0/005-411.sql
(will move prior merging))Once the cost informations are saved, the formula is displayed with its values on cost history edition.