Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 623: Search resources with no relationship #624

Merged
merged 1 commit into from Jan 30, 2020

Conversation

veggiematts
Copy link
Contributor

@veggiematts veggiematts commented Jan 30, 2020

Background: see issue #623

Currently, resources can be filtered with the following relationship criteria:

  • All: all resources are displayed (child, parent, or no relationship)
  • Parent: only parent resources are displayed
  • Child: only child resources are displayed

This patch adds the following criteria:

  • None: only resources that are neither parent nor child are displayed
    (ie: only resources with no relationship)

Test plan:

  • Perform a search on the resources index page, with 'None' in the Relationship
    dropdown list.
  • Check that only the resources with no relationship are displayed.

Currently, resources can be filtered with the following relationship criteria:

 - All: all resources are displayed (child, parent, or no relationship)
 - Parent: only parent resources are displayed
 - Child: only child resources are displayed

This patch adds the following criteria:

 - None: only resources that are neither parent nor child are displayed
   (ie: only resources with no relationship)

Test plan:
 - Perform a search on the resources index page, with 'None' in the Relationship
   dropdown list.
 - Check that only the resources with no relationship are displayed.
@veggiematts veggiematts added the enhancement This is an enhancement (not a bug) label Jan 30, 2020
@sbouis
Copy link

sbouis commented Jan 30, 2020

Ok, it works as intented.
The new value "none" is displayed in the drop-down menu "relationship".
I searched for "parent", "child" and "none" and I have the resources corresponding for each search.

@veggiematts
Copy link
Contributor Author

Thanks for testing @sbouis
Small change, unlikely to break anything, I'm merging this.

@veggiematts veggiematts merged commit c3a19b6 into coral-erm:development Jan 30, 2020
@veggiematts veggiematts added this to Documentation needed in February 2020 release Feb 10, 2020
@rtatterson rtatterson moved this from Documentation needed to Documentation updated in February 2020 release Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement (not a bug)
Projects
February 2020 release
Documentation updated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants