-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong exit status #2117
Comments
I've had the same result when using anchor-cli 0.25.0 Line 2030 in 6baed77
|
if you run |
Same happens with |
Yeah this is causing us the same issue in github workflows. I'd like to see this issue get fixed. It's probably an easy fix, but I have too much on my plate at the moment. |
Looks like this is fixed upstream (tested when building from source). The reason @armaniferrante any way to cut a new release, or at the very least create a v0.2X.X tag so EDIT: You can use the latest upstream cli built from source in your CI/CD for now: # Optional --rev <SHA> to freeze source
cargo install --git https://github.com/project-serum/anchor anchor-cli --locked --force |
Great to hear 👍! I'll look for the fix because I'm curious to see what the problem was. Do we know the commit/pr? Because it should link to this issue for people to see. |
It seems like this is still an issue in 0.26.0 🤔 |
Looks fine to me? Maybe this is a mac thing. Either way, open to checking out any PRs that purport to solve the issue.
|
I have some further information: If I check out the commit of the 0.26.0 tag and build the cli, I'm able to use the executable in target to build the broken anchor program and have it return the correct status. If I run anchor 0.26.0 installed through avm I have the wrong exit status. I reinstalled 0.26.0 through avm and noticed: |
PR opened! |
Description
Anchor commands (that wrap around other commands like
cargo build-bpf
) that result in something failing still return exit status 0.Steps to reproduce
Actual result
exit status is 0
Expected result
exit status is equal to the exit status of the underlying command. (something non zero as compilation fails)
System
anchor-cli: 0.24.2
avm: 0.24.2
Apple M1 Pro
rustc 1.63.0
solana-cargo-build-bpf 1.10.32
bpf-tools v1.27
The text was updated successfully, but these errors were encountered: