lang: use phantomdata in account type instead of '_account: T' #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let mut empty = &[][..]; | ||
| Ok(Program::new( | ||
| info.clone(), | ||
| T::try_deserialize(&mut empty)?, |
There was a problem hiding this comment.
We should remove this trait bound and the associated implementations as well.
There was a problem hiding this comment.
the Deserialize trait bound for T?
There was a problem hiding this comment.
yea makes sense
There was a problem hiding this comment.
the dex struct also implements AccountSerialize. Was that intentional?
There was a problem hiding this comment.
Sounds like a mistake. Can remove that too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1140