Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Improve error handling of toolchain overrides #2700

Conversation

acheroncrypto
Copy link
Collaborator

Problem

  • If solana_version override restoration fails, it fails silently — there is no indication of failure
  • [toolchain] override and restoration code is similar but they live in separate functions

Summary of changes

  • Show error if toolchain restoration fails
  • Failure during one of the toolchain restoration steps no longer fails the entire function
  • Set toolchain override and restoration in the same place

Copy link

vercel bot commented Nov 13, 2023

@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@acheroncrypto acheroncrypto merged commit cded9de into coral-xyz:master Nov 13, 2023
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant