Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts: Add IDL seed types #2752

Merged
merged 11 commits into from
Jan 4, 2024
Merged

Conversation

Shiva953
Copy link
Contributor

🤖 This pull request was created by https://app.gib.work/r/Ql3a0gKk/anchor
⚡️ Payment for bounty is immediately sent to the contributor after merge.

Signed-off-by: Shiva953 <b22070@students.iitmandi.ac.in>
Copy link

vercel bot commented Dec 30, 2023

@Shiva953 is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

Before we merge, could you also add a CHANGELOG entry for this?

ts/packages/anchor/src/idl.ts Outdated Show resolved Hide resolved
ts/packages/anchor/src/idl.ts Outdated Show resolved Hide resolved
ts/packages/anchor/src/idl.ts Outdated Show resolved Hide resolved
Signed-off-by: Shiva953 <b22070@students.iitmandi.ac.in>
Signed-off-by: Shiva953 <b22070@students.iitmandi.ac.in>
@Shiva953
Copy link
Contributor Author

Shiva953 commented Jan 1, 2024

@acheroncrypto any updates?

@acheroncrypto
Copy link
Collaborator

@acheroncrypto acheroncrypto changed the title GIB💎WORK Bounty - Pull Request Made To anchor ts: Add IDL seed types Jan 1, 2024
Signed-off-by: Shiva953 <b22070@students.iitmandi.ac.in>
@Shiva953
Copy link
Contributor Author

Shiva953 commented Jan 2, 2024

The tests now pass, added the necessary missing types in IdlSeedConst and IdlSeedArg, also modified the error message a bit(since accountDesc.pda.programId.kind included inside the throw New Error() was resulting in type never for accountDesc.pda.programId)

Screenshot 2024-01-02 at 7 16 34 PM

Signed-off-by: Shiva953 <b22070@students.iitmandi.ac.in>
Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a formatting error, you can fix it by running yarn lint:fix.

Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@acheroncrypto acheroncrypto merged commit 1a6b506 into coral-xyz:master Jan 4, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants