Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labelset and label views: Javascript tests + modernizing #434

Open
4 tasks
StephenChan opened this issue Feb 2, 2022 · 0 comments
Open
4 tasks

Labelset and label views: Javascript tests + modernizing #434

StephenChan opened this issue Feb 2, 2022 · 0 comments
Labels
refactor unittests
Milestone
3.0

Comments

@StephenChan
Copy link
Member

StephenChan commented Feb 2, 2022 •
edited

Tests should mostly be QUnit, with potentially a few LiveServerTestCases. Modernizing means:

  • Using ES6 classes and syntax
  • Not relying on jQuery too much, including using fetch instead of jQuery.ajax

4 files that I'd put under this issue:

  • LabelList.js
  • LabelMain.js
  • LabelNew.js
  • LabelsetAdd.js (the most complex one)

I'll group LabelsetImport.js along with upload (issue #436).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor unittests
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@StephenChan