VTX-3411: fix serialisation for multi part struct #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsdvh
commented
Dec 6, 2023
| @@ -46,7 +46,7 @@ walkdir = "2" | |||
| # Cloud storage support | |||
| base64 = { version = "0.21", default-features = false, features = ["std"], optional = true } | |||
| hyper = { version = "0.14", default-features = false, optional = true } | |||
| quick-xml = { version = "0.30.0", features = ["serialize", "overlapped-lists"], optional = true } | |||
| quick-xml = { git = "https://github.com/tafia/quick-xml.git", rev="db8546a", features = ["serialize", "overlapped-lists"], optional = true } | |||
There was a problem hiding this comment.
in the latest version of the library (not released yet) escape level was decreased to Partial, meaning it would not escape " by default
fsdvh
force-pushed
the
object-store0.7.1-cx.1
branch
from
89cd56f
to
88dd767
Compare
fsdvh
changed the title
thinkharderdev
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this ticket I'm trying to address a serialization issue related to multipart upload