patch - adding severity option to prometheusrules alert (#104)

coralogix · May 12, 2024 · d63821f · d63821f
1 parent 4b62434
commit d63821f
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 4 deletions.
diff --git a/config/samples/prometheusrules/monitoring.coreos.com_prometheusrules.yaml b/config/samples/prometheusrules/monitoring.coreos.com_prometheusrules.yaml
@@ -22,6 +22,8 @@ spec:
           for: 5m
           annotations:
             cxMinNonNullValuesPercentage: "20"
+          labels:
+            severity: critical
     - name: example.rules2
       interval: "70s"
       rules:
@@ -33,4 +35,6 @@ spec:
             expr: histogram_quantile(0.99, sum(irate(istio_request_duration_seconds_bucket{reporter="source",destination_service=~"ingress-annotation-test-svc.example-app.svc.cluster.local"}[1m])) by (le, destination_workload)) > 0.2
             for: 5m
             annotations:
-              cxMinNonNullValuesPercentage: "20"
+              cxMinNonNullValuesPercentage: "20"
+            labels:
+                severity: info
diff --git a/controllers/prometheusrule_controller.go b/controllers/prometheusrule_controller.go
@@ -268,8 +268,14 @@ func prometheusInnerRuleToCoralogixAlert(prometheusRule prometheus.Rule) coralog
 		timeWindow = prometheusAlertForToCoralogixPromqlAlertTimeWindow["1m"]
 	}
 
+	severity := coralogixv1alpha1.AlertSeverityInfo
+	if severityStr, ok := prometheusRule.Labels["severity"]; ok {
+		severityStr = strings.ToUpper(severityStr[:1]) + severityStr[1:]
+		severity = coralogixv1alpha1.AlertSeverity(severityStr)
+	}
+
 	return coralogixv1alpha1.AlertSpec{
-		Severity: coralogixv1alpha1.AlertSeverityInfo,
+		Severity: severity,
 		NotificationGroups: []coralogixv1alpha1.NotificationGroup{
 			{
 				Notifications: []coralogixv1alpha1.Notification{

diff --git a/tests/e2e/promatheusrules/00-install.yaml b/tests/e2e/promatheusrules/00-install.yaml
@@ -18,6 +18,8 @@ spec:
           for: 5m
           annotations:
             cxMinNonNullValuesPercentage: "20"
+          labels:
+            severity: critical
     - name: example.rules2
       interval: "70s"
       rules:
@@ -29,4 +31,6 @@ spec:
           expr: histogram_quantile(0.99, sum(irate(istio_request_duration_seconds_bucket{reporter="source",destination_service=~"ingress-annotation-test-svc.example-app.svc.cluster.local"}[1m])) by (le, destination_workload)) > 0.2
           for: 5m
           annotations:
-            cxMinNonNullValuesPercentage: "20"
+            cxMinNonNullValuesPercentage: "20"
+          labels:
+              severity: info
diff --git a/tests/e2e/promatheusrules/01-assert.yaml b/tests/e2e/promatheusrules/01-assert.yaml
@@ -29,7 +29,7 @@ status:
     - notifications:
         - notifyOn: TriggeredOnly
           retriggeringPeriodMinutes: 5
-  severity: Info
+  severity: Critical
   showInInsight:
     notifyOn: TriggeredOnly
     retriggeringPeriodMinutes: 5