This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
Change k8s.container.name to k8s.pod.name in subsystem attributes list #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
matej-g
requested review from
avivgold098,
oded-dd,
nicolastakashi,
ArthurSens and
Razgoldenberg1
as code owners
povilasv
approved these changes
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We preferably want to include higher-level objects in the subsystem name (deployment, stateful set, pod etc.) instead of the container name, which is too specific. This small fix changes the container name attribute to pod name to pick correct attributes for pod.
How Has This Been Tested?
Manually.
Checklist: