Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request library has been deprecated #30

Open
ofekdeitch-oligo opened this issue Mar 22, 2023 · 4 comments
Open

request library has been deprecated #30

ofekdeitch-oligo opened this issue Mar 22, 2023 · 4 comments

Comments

@ofekdeitch-oligo
Copy link

According to their npm page:
"As of Feb 11th 2020, request is fully deprecated. No new changes are expected land. In fact, none have landed for some time."

I think we ought to migrate to some other library that is still being actively maintained.
Thanks 👍
@igor-vishnevsky
Copy link

Or at least update the version to 2.88.2 #23 because of CVE-2023-28155

@snyk-bot snyk-bot mentioned this issue Jun 25, 2023
Open
@saharaquant
Copy link

Can anyone from the team help? @juan-coralogix

@geoynomous
Copy link

geoynomous commented Oct 6, 2023 •
edited
Loading

request is deprecated 3 years - any plans to choose an alternative?

And in the same light: Snyk reports that tough-cookie@4.1.3 is also used by your 1.1.28 logger

YonatanKiron added a commit that referenced this issue Jan 1, 2024
@YonatanKiron
Update SDK to solve vulnerability issues
0bf0210 
Like deprecation of request package

Solves:
#30
#23
#21
YonatanKiron added a commit that referenced this issue Jan 1, 2024
@YonatanKiron
Update SDK to solve vulnerability issues
bda542a 
Like deprecation of request package

Solves:
#30
#23
#21
YonatanKiron added a commit that referenced this issue Jan 1, 2024
@YonatanKiron
Update SDK to solve vulnerability issues
27a0b1c 
Like deprecation of request package

Solves:
#30
#23
#21
YonatanKiron added a commit that referenced this issue Jan 2, 2024
@YonatanKiron
Update SDK to solve vulnerability issues
34ccb8c 
Like deprecation of request package

Solves:
#30
#23
#21
Signed-off-by: Yonatan Kiron <yonatan.kiron@coralogix.com>
YonatanKiron added a commit that referenced this issue Jan 2, 2024
@YonatanKiron
Update SDK to solve vulnerability issues
1c2e90f 
Like deprecation of request package

Solves:
#30
#23
#21
Signed-off-by: Yonatan Kiron <yonatan.kiron@coralogix.com>
YonatanKiron added a commit that referenced this issue Jan 2, 2024
@YonatanKiron
Feature/resolve vulnerability issues (#35)
2e4eb74 
* Update SDK to solve vulnerability issues

Like deprecation of request package

Solves:
#30
#23
#21
Signed-off-by: Yonatan Kiron <yonatan.kiron@coralogix.com>

* Change api endpoint to ingress as api is legacy

Signed-off-by: Yonatan Kiron <yonatan.kiron@coralogix.com>

* Add github action

Signed-off-by: Yonatan Kiron <yonatan.kiron@coralogix.com>

* Add proxy test example

Signed-off-by: Yonatan Kiron <yonatan.kiron@coralogix.com>

* Dist commit

Signed-off-by: Yonatan Kiron <yonatan.kiron@coralogix.com>

* Remove privateKey annotations

Signed-off-by: Yonatan Kiron <yonatan.kiron@coralogix.com>

---------

Signed-off-by: Yonatan Kiron <yonatan.kiron@coralogix.com>
@royfur
Copy link

royfur commented Jan 3, 2024

New version was released that address the security vulnerability reported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@saharaquant @geoynomous @igor-vishnevsky @ofekdeitch-oligo @royfur