[Feature] Allow Bucket Destruction via Code

[hikerspath]

Description

User will end up with the following error message when attempting to destroy presently...

│ Error: Instance cannot be destroyed
│
│   on .terraform/modules/coralogix_s3/modules/provisioning/s3-archive/main.tf line 16:
│   16: resource "aws_s3_bucket" "logs_bucket_name" {
│
│ Resource module.coralogix_s3.aws_s3_bucket.logs_bucket_name[0] has lifecycle.prevent_destroy set, but the plan calls for this resource to be destroyed. To avoid this error and continue with the plan, either
│ disable lifecycle.prevent_destroy or reduce the scope of the plan using the -target flag.

How Has This Been Tested?

Setting lifecycle to false and running code manually after downloading the module w/ terraform init and then running a terraform destroy.

Checklist:

• I have updated the relevant example in the examples directory for the module.
• I have updated the relevant test file for the module.
• This change does not affect module (e.g. it's readme file change)

[guyrenny]

Hi @hikerspath, thank you for your suggestion,
Just need to add small changes:

1. When we add a new variable to module we also need to add him in the readme file of the module and to the variable.tf under the example folder examples/s3-archive/varibales.tf
2. We want to keep track on the changes that we make, so if you could also add an entry in the changelog file of the module.

Other then this changes everything looks good.