Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move linting to webpack config #147

Closed
okbel opened this issue Dec 9, 2016 · 2 comments
Closed

Move linting to webpack config #147

okbel opened this issue Dec 9, 2016 · 2 comments
Assignees

Comments

@okbel
Copy link
Contributor

okbel commented Dec 9, 2016

Problem

Linting is sometimes omitted or it takes a lot to run. Running it with webpack will decrease the wait and improve the developer experience.

Solution

This could easily be arranged by adding this to our webpack.config file.

      {
        enforce: 'pre',
        test: /\.js$/,
        loader: 'eslint-loader',
        exclude: /node_modules/
      },

This way we can remove the linting hooks, only leaving the tests.

Thoughts?

@okbel okbel self-assigned this Dec 9, 2016
@wyattjoh
Copy link
Collaborator

I think we can definitely add this to the webpack pipeline but it makes sense to me to keep the project wide linting in place as a "catch-all".

@jde
Copy link

jde commented Jan 26, 2017

+1 to keeping our linting rules in a single place since they apply to both FE and node code. @okbel, how much faster would it be to have linting in webpack? Do you think the performance gains you speak of are worth forking the linting rules?

@wyattjoh wyattjoh closed this as completed Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants