Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Coraza v3.2.1 and several dependencies #282

Merged
merged 6 commits into from
Jul 2, 2024

Conversation

M4tteoP
Copy link
Member

@M4tteoP M4tteoP commented Jun 20, 2024

  • Updates to Coraza v3.2
  • Udates tinygo ci and min version to 0.31.2 (aligned with the tinygo tests run in Coraza upstream)
  • CI: Updates envoy images
  • CI: sets fail-fast: false. Tests are flaky and making the two independent will help reduce the number of re-tries to have the PRs green.

This PR also unblocks #263

TODO: Update coraza-wasilibs dependency once corazawaf/coraza-wasilibs#17 is merged and a new version is tagged

@M4tteoP M4tteoP requested a review from jcchavezs as a code owner June 20, 2024 22:53
@M4tteoP M4tteoP marked this pull request as draft June 20, 2024 23:00
@M4tteoP
Copy link
Member Author

M4tteoP commented Jun 20, 2024

Note: I reverted tinygo update. Taking a quick look, because of tinygo-org/tinygo#4175, looks like that we need to also upgrade Go to 1.21 to make it work

@M4tteoP M4tteoP marked this pull request as ready for review June 20, 2024 23:35
@M4tteoP M4tteoP changed the title Updates to Coraza v3.2 and several dependencies Updates to Coraza v3.2.1 and several dependencies Jun 23, 2024
@M4tteoP
Copy link
Member Author

M4tteoP commented Jun 24, 2024

Update: I managed to upgrade to TinyGo 0.31.2 and left some comments about the next update steps

@@ -58,5 +58,3 @@ testoverride:
'934120-39': 'Rule 934120 partially detected. With HTTP/1.1 Envoy return 400. With HTTP/2 Enclosed alphanumerics not detected. Coraza Side'
'932200-13': 'Unfortunate match inside logs against a different rule log. wip'
'930110-7': 'Coraza/CRS side: See https://github.com/corazawaf/coraza/pull/1081'
'942440-19': 'Addressed via https://github.com/corazawaf/coraza/pull/1061 in Coraza v3.2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@M4tteoP
Copy link
Member Author

M4tteoP commented Jul 2, 2024

Rebased and merging!

@M4tteoP M4tteoP merged commit de6279b into corazawaf:main Jul 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants