fix: race condition on StrID

[M4tteoP]

WIP.
Implements StrID at rule parsing time in order to fix race conditions introduced by the lazy pattern. It basically creates the variable alongside the ID variable creation.
I'm still unsure about the StrRuleID_ name. The goal is to explain that it is not always just the string of ID_, but it is the "displayed" ID, so for chained rules, the displayed id is the parent id even if the inner rule (being an inner rule) has the 0 value ID.

Fixes #1083

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.06%. Comparing base (4ff1f76) to head (212eca5).
Report is 53 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
+ Coverage   82.72%   83.06%   +0.34%     
==========================================
  Files         162      164       +2     
  Lines        9080     7671    -1409     
==========================================
- Hits         7511     6372    -1139     
+ Misses       1319     1044     -275     
- Partials      250      255       +5     

Flag	Coverage Δ
default	83.06% <100.00%> (+5.22%)	⬆️
examples	83.06% <100.00%> (+56.63%)	⬆️
ftw	83.06% <100.00%> (+35.69%)	⬆️
ftw-multiphase	83.06% <100.00%> (+33.52%)	⬆️
tinygo	83.06% <100.00%> (+7.66%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jcchavezs]

Since this is mainly used in logs maybe call IDForLog_?

[M4tteoP]

Confirming that the added test can reproduce the reported race condition:

▶ go test -timeout 60s -tags sqlite -run ^TestHttpServerConcurrent$ github.com/corazawaf/coraza/v3/examples/http-server -race
[...]
==================
WARNING: DATA RACE
Read at 0x00c0001223a8 by goroutine 88:
  github.com/corazawaf/coraza/v3/internal/corazarules.(*RuleMetadata).StrID()
      /Coraza/internal/corazarules/rule.go:89 +0x34
2024/06/22 14:52:35 [DEBUG] Evaluating phase tx_id="SynVkYwHnVfRyRdXEkR" phase=5
  github.com/corazawaf/coraza/v3/internal/corazawaf.(*Rule).doEvaluate()
      /Coraza/internal/corazawaf/rule.go:197 +0x120
2024/06/22 14:52:35 [DEBUG] Finished phase tx_id="SynVkYwHnVfRyRdXEkR" phase=5
  github.com/corazawaf/coraza/v3/internal/corazawaf.(*Rule).Evaluate()
      /Coraza/internal/corazawaf/rule.go:179 +0x364
  github.com/corazawaf/coraza/v3/internal/corazawaf.(*RuleGroup).Eval()
      /Coraza/internal/corazawaf/rulegroup.go:219 +0x670
  github.com/corazawaf/coraza/v3/internal/corazawaf.(*Transaction).ProcessRequestHeaders()
      /Coraza/internal/corazawaf/transaction.go:814 +0xf0
  github.com/corazawaf/coraza/v3/http.processRequest()
      /Coraza/http/middleware.go:63 +0x330
2024/06/22 14:52:35 [DEBUG] Transaction marked for audit logging tx_id="SynVkYwHnVfRyRdXEkR"
  github.com/corazawaf/coraza/v3/http.WrapHandler.func3()
      /Coraza/http/middleware.go:155 +0xb8
  net/http.HandlerFunc.ServeHTTP()
      /go1.20.7/src/net/http/server.go:2122 +0x48
  net/http.serverHandler.ServeHTTP()
      /go1.20.7/src/net/http/server.go:2936 +0x548
  net/http.(*conn).serve()
      /go1.20.7/src/net/http/server.go:1995 +0x8d8
  net/http.(*Server).Serve.func3()
      /go1.20.7/src/net/http/server.go:3089 +0x4c

Previous write at 0x00c0001223a8 by goroutine 73:
  github.com/corazawaf/coraza/v3/internal/corazarules.(*RuleMetadata).StrID()
      /Coraza/internal/corazarules/rule.go:94 +0x84
  github.com/corazawaf/coraza/v3/internal/corazawaf.(*Rule).doEvaluate()
      /Coraza/internal/corazawaf/rule.go:197 +0x120
  github.com/corazawaf/coraza/v3/internal/corazawaf.(*Rule).Evaluate()
      /Coraza/internal/corazawaf/rule.go:179 +0x364
  github.com/corazawaf/coraza/v3/internal/corazawaf.(*RuleGroup).Eval()
      /Coraza/internal/corazawaf/rulegroup.go:219 +0x670
  github.com/corazawaf/coraza/v3/internal/corazawaf.(*Transaction).ProcessRequestHeaders()
      /Coraza/internal/corazawaf/transaction.go:814 +0xf0
  github.com/corazawaf/coraza/v3/http.processRequest()
      /Coraza/http/middleware.go:63 +0x330
  github.com/corazawaf/coraza/v3/http.WrapHandler.func3()
      /Coraza/http/middleware.go:155 +0xb8
  net/http.HandlerFunc.ServeHTTP()
      /go1.20.7/src/net/http/server.go:2122 +0x48
  net/http.serverHandler.ServeHTTP()
      /go1.20.7/src/net/http/server.go:2936 +0x548
  net/http.(*conn).serve()
      /go1.20.7/src/net/http/server.go:1995 +0x8d8
  net/http.(*Server).Serve.func3()
      /go1.20.7/src/net/http/server.go:3089 +0x4c