registers pmFromDataset, fixes Dataset propagation, adds tests #777
Conversation
| @@ -105,7 +105,7 @@ Go build tags can tweak certain functionality at compile-time. These are for adv | |||
| have compatibility guarantees across minor versions - use with care. | |||
|
|
|||
| - coraza.disabled_operators.* - excludes the specified operator from compilation. Particularly useful if overriding | |||
| the operator with `operators.Register` to reduce binary size / startup overhead. | |||
| the operator with `plugins.RegisterOperator` to reduce binary size / startup overhead. | |||
There was a problem hiding this comment.
With #734 operators have been moved to an internal package, from an user standpoint it is better to point out directly plugins.RegisterOperator, isn't it?
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v3/dev #777 +/- ##
=======================================
Coverage 81.85% 81.86%
=======================================
Files 153 153
Lines 8188 8192 +4
=======================================
+ Hits 6702 6706 +4
Misses 1267 1267
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
We added this for proxy-wasm but ended up not needing it. Do we know of any other users of the feature? We might consider actually removing it if we don't have a usecase anymore. |
The usecase I was thinking about is proxy-wasm, and the possibility to add new custom rules to a Wasm that has already been built (and maybe distributed). I think it is still a scenario where we have no alternatives to |
This PR proses to:
pmFromDatasetoperator. It has been added alongside ipMatchFromDataset, the latter is properly registered, but not the first. I guess we just forgot it, I think that it is still a valuable operator.options.Datasetspropagation: Inside pmFromDataset and ipMatchFromDataset the Datasets slice was always ending to be empty resulting in an error not being able to find the dataset.operators_with_datasettests for both pmFromDataset and ipMatchFromDataset.