Validate audit log parts #779
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v3/dev #779 +/- ##
==========================================
- Coverage 81.86% 81.79% -0.07%
==========================================
Files 153 153
Lines 8192 8207 +15
==========================================
+ Hits 6706 6713 +7
- Misses 1267 1274 +7
- Partials 219 220 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
internal/actions/ctl.go
Outdated
| @@ -112,7 +112,16 @@ func (a *ctlFn) Evaluate(_ plugintypes.RuleMetadata, txS plugintypes.Transaction | |||
| tx.AuditEngine = ae | |||
| case ctlAuditLogParts: | |||
| // TODO lets switch it to a string | |||
There was a problem hiding this comment.
| // TODO lets switch it to a string |
types/waf.go
Outdated
| @@ -106,6 +106,30 @@ type AuditLogPart byte | |||
| // Z: Final boundary, signifies the end of the entry (mandatory). | |||
| type AuditLogParts []AuditLogPart | |||
|
|
|||
| var validOpts = map[AuditLogPart]bool{ | |||
There was a problem hiding this comment.
In order to save some bytes we could turn this into map[AuditLogPart]struct{} as struct{} allocates zero bytes.
There was a problem hiding this comment.
thanks, I don't know this way before
| } | ||
| func TestInvalidAuditLog(t *testing.T) { | ||
| AuditLogParts, err := types.ParseAuditLogParts("ABCDEFGHIJKLMN") | ||
| if err == nil || !reflect.DeepEqual(AuditLogParts, types.AuditLogParts("")) { |
There was a problem hiding this comment.
I'd avoid using reflection and cast AuditLogParts to string instead.
| @@ -429,6 +430,28 @@ func TestAuditLog(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestParseAuditLog(t *testing.T) { | |||
| tx := makeTransaction(t) | |||
There was a problem hiding this comment.
I wonder why we need to create a transaction to test the log parts.
There was a problem hiding this comment.
sorry,I just cody the TestAuditLog()
|
Thanks for this! I left some comments. |
|
Great work @Hayak3 |
fix #678