feat: adds auditlog plugins API #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v3/dev #787 +/- ##
==========================================
- Coverage 81.85% 81.24% -0.62%
==========================================
Files 153 155 +2
Lines 8252 8424 +172
==========================================
+ Hits 6755 6844 +89
- Misses 1277 1352 +75
- Partials 220 228 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
anuraaga
reviewed
May 8, 2023
anuraaga
approved these changes
May 12, 2023
jcchavezs
commented
May 14, 2023
| HostIP: tx.variables.serverAddr.Get(), | ||
| HostPort: hostPort, | ||
| ServerID: tx.variables.serverName.Get(), // TODO check | ||
| alTransaction = auditlog.Transaction{ |
There was a problem hiding this comment.
This code specifically requires the AuditLogPartAuditLogHeader(aka A) part to be present and be the first one declared. The first condition is right as it is mandatory but the second isn't so I will change that in a next PR to not to grow this one.
jcchavezs
changed the title
fzipi
approved these changes
May 15, 2023
anuraaga
approved these changes
May 16, 2023
Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things that need to happen together:
auditlogpackage into an internal packageauditlog.Config.Writeras it was half baked API for extending auditlogs and exposed an internal APIexperimentalfunctions to register audit log writer and formatterHopefully this will be the last breaking change for public API.