breaking: removes code parameter from ErrorLog and AuditLog

[M4tteoP]

follows #795 reasonings. Proposes to remove the code parameter from ErrorLog and AuditLog.

[codecov]

Codecov Report

Patch coverage: 57.14% and no project coverage change.

Comparison is base (eed5643) 81.84% compared to head (7026970) 81.85%.

Additional details and impacted files

@@           Coverage Diff           @@
##           v3/dev     #800   +/-   ##
=======================================
  Coverage   81.84%   81.85%           
=======================================
  Files         156      156           
  Lines        8663     8662    -1     
=======================================
  Hits         7090     7090           
+ Misses       1342     1341    -1     
  Partials      231      231           

Flag	Coverage Δ
default	76.16% <50.00%> (+<0.01%)	⬆️
examples	25.42% <50.00%> (+<0.01%)	⬆️
ftw	47.25% <20.00%> (+<0.01%)	⬆️
ftw-multiphase	49.39% <20.00%> (+<0.01%)	⬆️
tinygo	74.31% <50.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
internal/corazawaf/transaction.go	78.27% <0.00%> (+0.05%)	⬆️
internal/corazarules/rule_match.go	60.65% <50.00%> (ø)
examples/http-server/main.go	70.27% <100.00%> (ø)
testing/engine.go	58.73% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jcchavezs]

Ping @anuraaga @jptosso

…

On Thu, 25 May 2023, 12:27 codecov[bot], ***@***.***> wrote: Codecov <https://app.codecov.io/gh/corazawaf/coraza/pull/800?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corazawaf> Report Patch coverage: *57.14*% and no project coverage change. Comparison is base (eed5643) <https://app.codecov.io/gh/corazawaf/coraza/commit/eed5643b9f428a289fb8dcd66662c033051f4d33?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corazawaf> 81.84% compared to head (7026970) <https://app.codecov.io/gh/corazawaf/coraza/pull/800?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corazawaf> 81.85%. Additional details and impacted files @@ Coverage Diff @@## v3/dev #800 +/- ## ======================================= Coverage 81.84% 81.85% ======================================= Files 156 156 Lines 8663 8662 -1 ======================================= Hits 7090 7090 + Misses 1342 1341 -1 Partials 231 231 Flag Coverage Δ default 76.16% <50.00%> (+<0.01%) ⬆️ examples 25.42% <50.00%> (+<0.01%) ⬆️ ftw 47.25% <20.00%> (+<0.01%) ⬆️ ftw-multiphase 49.39% <20.00%> (+<0.01%) ⬆️ tinygo 74.31% <50.00%> (+<0.01%) ⬆️ Flags with carried forward coverage won't be shown. Click here <https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corazawaf#carryforward-flags-in-the-pull-request-comment> to find out more. Impacted Files <https://app.codecov.io/gh/corazawaf/coraza/pull/800?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corazawaf> Coverage Δ internal/corazawaf/transaction.go <https://app.codecov.io/gh/corazawaf/coraza/pull/800?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corazawaf#diff-aW50ZXJuYWwvY29yYXphd2FmL3RyYW5zYWN0aW9uLmdv> 78.27% <0.00%> (+0.05%) ⬆️ internal/corazarules/rule_match.go <https://app.codecov.io/gh/corazawaf/coraza/pull/800?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corazawaf#diff-aW50ZXJuYWwvY29yYXphcnVsZXMvcnVsZV9tYXRjaC5nbw==> 60.65% <50.00%> (ø) examples/http-server/main.go <https://app.codecov.io/gh/corazawaf/coraza/pull/800?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corazawaf#diff-ZXhhbXBsZXMvaHR0cC1zZXJ2ZXIvbWFpbi5nbw==> 70.27% <100.00%> (ø) testing/engine.go <https://app.codecov.io/gh/corazawaf/coraza/pull/800?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corazawaf#diff-dGVzdGluZy9lbmdpbmUuZ28=> 58.73% <100.00%> (ø) ☔ View full report in Codecov by Sentry <https://app.codecov.io/gh/corazawaf/coraza/pull/800?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corazawaf> . 📢 Do you have feedback about the report comment? Let us know in this issue <https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=corazawaf> . — Reply to this email directly, view it on GitHub <#800 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXOYAUQ26ZRL77C7IHP5TTXH4XY7ANCNFSM6AAAAAAYOT72V4> . You are receiving this because your review was requested.Message ID: ***@***.***>

[jptosso]

If we change the error log, log parsers will break :( (?)

[fzipi]

Forget my last comment, we are using interfaces.

[fzipi]

After doing a second pass, it will be a breaking compatibility change, but I get the why so 👍

[jptosso]