chore: improve GetField logic #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
anuraaga
reviewed
Oct 31, 2023
internal/corazawaf/transaction.go
Outdated
| for i, c := range matches { | ||
| // in the most common scenario filteredMatches length will be | ||
| // the same as matches length, so we avoid allocating per result | ||
| filteredMatches := make([]types.MatchData, len(matches)) |
There was a problem hiding this comment.
Think it's good to use make([], 0, len) and append since it basically allows Go to take care of the filteredCount variable while still preallocating
|
Thanks @jptosso. Specifically this line coraza/internal/corazawaf/transaction.go Line 582 in 4b1b82d |
That line was deleted |
|
I like the implementation... can we find tests for the else paths? |
anuraaga
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce number of allocations, loops, and complexity.