Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filling variables struct to complete audit info #968

Merged
merged 5 commits into from Jan 31, 2024

Conversation

CArellanoOrbik
Copy link
Contributor

Thank you for contributing to Coraza WAF, your effort is greatly appreciated
Before submitting check if what you want to add to coraza list meets quality standards before sending pull request. Thanks!

Make sure that you've checked the boxes below before you submit PR:

Thanks for your contribution ❤️

Signed-off-by: Cristobal ARELLANO <c.arellano@orbik-cybersecurity.com>
@CArellanoOrbik CArellanoOrbik requested a review from a team as a code owner January 30, 2024 14:47
@CArellanoOrbik CArellanoOrbik changed the title filling variables struct to complete audit info fix: filling variables struct to complete audit info Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2161dea) 82.71% compared to head (d0c1060) 82.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #968      +/-   ##
==========================================
+ Coverage   82.71%   82.74%   +0.02%     
==========================================
  Files         162      162              
  Lines        9062     9056       -6     
==========================================
- Hits         7496     7493       -3     
+ Misses       1317     1315       -2     
+ Partials      249      248       -1     
Flag Coverage Δ
default 77.84% <100.00%> (+0.01%) ⬆️
examples 26.37% <100.00%> (-0.02%) ⬇️
ftw 47.37% <0.00%> (+0.03%) ⬆️
ftw-multiphase 49.55% <0.00%> (+0.03%) ⬆️
tinygo 75.40% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcchavezs
Copy link
Member

@CArellanoOrbik thanks for this! Could you please add a test for covering the change?

CArellanoOrbik and others added 2 commits January 30, 2024 22:36
Signed-off-by: Cristobal ARELLANO <c.arellano@orbik-cybersecurity.com>
@CArellanoOrbik
Copy link
Contributor Author

@jcchavezs I have just added two test, one for each fix :)

Signed-off-by: Cristobal ARELLANO <c.arellano@orbik-cybersecurity.com>
@CArellanoOrbik
Copy link
Contributor Author

@jcchavezs I have accidentally clicked in "request review". Could you approve it?

@jcchavezs jcchavezs merged commit a6e53a9 into corazawaf:main Jan 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants