Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDK version to every request #7

Closed
3 tasks
corbadoman opened this issue Nov 21, 2023 · 1 comment
Closed
3 tasks

Add SDK version to every request #7

corbadoman opened this issue Nov 21, 2023 · 1 comment
Assignees

Comments

@corbadoman
Copy link
Contributor

corbadoman commented Nov 21, 2023

Why

To get a understanding what SDKs our customers use we need to provide the SDK version in every API request.

TODOS

  • Add release version to go binary in some version constant/variable
  • Add this version to every request as an additional header: X-Corbado-SDK-Version (we use an additional header because we need to preserve the User-Agent field for the real user agent of the user of our customer)
  • Value: "Go SDK (release version)" so for example "Go SDK v0.3.0"

Competitors

@corbadovych
Copy link
Contributor

done in v0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants