Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom input range #46

Closed
wants to merge 1 commit into from

Conversation

danobot
Copy link

@danobot danobot commented Jul 16, 2018

This tweak allows for a configurable brightness input range.
If the LED strip hardware does not support brightness values below 150 (because the LED strip cannot operate at that low a voltage), the user can specify a min and a max brightness value.
The advantage of this is that the full range of values (0-255) can be used in Home Assistant, while internally it is converted to the requirements of the hardware (150-255).

Have applied this to brightness only because that is my use case. If this is a feature you want to merge let me know and we can discuss how to apply it to all RGB values.

@corbanmailloux
Copy link
Owner

I'm not sure how useful this change is for most people. I guess it makes sense, but I'm surprised if your LEDs are really off at ~59% (150/255). That seems like more of a LED or wiring issue in this case.

Do you think this is generally applicable for most light sets?

@danobot
Copy link
Author

danobot commented Dec 6, 2018

It depends on the type of LED. Some get really dim very quick. It's a relatively simple change and it's readable in that people understand what is going on as soon as they see the map function and constants.

@danobot danobot closed this Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants