Fix PHP Error when Term Taxonomy points to non-existing term_id

corcel · May 12, 2021 · 1c953d6 · 1c953d6
1 parent d1d6846
commit 1c953d6
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/src/Model/Post.php b/src/Model/Post.php
@@ -306,9 +306,11 @@ public function getTermsAttribute()
             return $taxonomy->taxonomy == 'post_tag' ?
                 'tag' : $taxonomy->taxonomy;
         })->map(function ($group) {
-            return $group->mapWithKeys(function ($item) {
-                return [$item->term->slug => $item->term->name];
-            });
+            return $group
+                ->filter(fn($item) => $item->term !== NULL)
+                ->mapWithKeys(function ($item) {
+                    return [$item->term->slug => $item->term->name];
+                });
         })->toArray();
     }
 

diff --git a/tests/Unit/Model/PostTest.php b/tests/Unit/Model/PostTest.php
@@ -334,6 +334,26 @@ public function test_it_can_have_term()
         $this->assertEquals('Bar', $post->keywords_str);
     }
 
+    /** @doesNotPerformAssertions */
+    public function test_it_can_handle_corrupted_term()
+    {
+        $post = factory(Post::class)->create();
+
+        $taxonomy = factory(Taxonomy::class)->create([
+            'term_id' => 0,
+            'taxonomy' => 'category'
+        ]);
+
+        $post->taxonomies()->attach(
+            $taxonomy->getKey(),
+            [
+                'term_order' => 0,
+            ]
+        );
+
+        $post->terms;
+    }
+
     public function test_it_can_have_author_relation()
     {
         $post = $this->createPostWithAuthor();