Make redeem flow handlers open #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c for redeemed tokens on the issuer`s side. Make ObserverAwareFinalityFlowHandler return a SignedTransaction if one was received.
ischasny
reviewed
May 5, 2020
...om/r3/corda/lib/tokens/workflows/flows/redeem/ConfidentialRedeemFungibleTokensFlowHandler.kt
Outdated
Show resolved
Hide resolved
|
It looks good to me. @roastario could you please have a look whether it rings any bells? |
ischasny
previously approved these changes
May 7, 2020
roastario
approved these changes
May 21, 2020
roastario
added a commit
that referenced
this pull request
Sep 25, 2020
* Make redeem flow handlers open (#199) * Make redeem flow handlers open to allow adding custom processing logic for redeemed tokens on the issuer`s side. Make ObserverAwareFinalityFlowHandler return a SignedTransaction if one was received. * Undo removing a flow Co-authored-by: Stefano Franz <stefano.franz@r3.com> * Put Workflows Jar on a diet - exclude all corda runtime files (#206) * keep * put workflows jar on a bit of a diet * Add serialization env to OwnerMigration * fix migration for 4.6 Co-authored-by: Andrius Dagys <andrius.dagys@r3.com> Co-authored-by: Stefano Franz <stefano.franz@r3.com> Co-authored-by: Stefano Franz <roastario@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to allow adding custom processing logic for redeemed tokens on the issuer`s side.
Right now there is no way of tracking or processing redeemed tokens for the issuer without using the deprecated internal transaction RPC feed or copying and re-implementing the redeem flows.
The simplest fix seems to be making the handlers open for subclassing.