chore: Update last_login field on User model
#197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpinto-cdd
requested changes
Dec 20, 2022
Since in our project the method `django.contrib.auth.apps.AuthConfig.ready` will not be executed (because that app is not in `INSTALLED_APPS`) the function `django.contrib.auth.models.update_last_login` will not be registered to the signal `django.contrib.auth.signals.user_logged_in`. Ref: https://cordada.aha.io/features/COMPCLDATA-179 Ref: cordada/fd-secrets-manager#28 Ref: #5
svillegas-cdd
force-pushed
the
task/COMPCLDATA-179-fix-updating-of-user-last-login
branch
from
c286b57
to
63b78e7
Compare
fpinto-cdd
approved these changes
Dec 20, 2022
svillegas-cdd
deleted the
task/COMPCLDATA-179-fix-updating-of-user-last-login
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since in our project the method
django.contrib.auth.apps.AuthConfig.readywill not be executed (because that app is not inINSTALLED_APPS) the functiondjango.contrib.auth.models.update_last_loginwill not be registered to the signaldjango.contrib.auth.signals.user_logged_in.Ref: https://cordada.aha.io/features/COMPCLDATA-179
Ref: https://github.com/fyntex/fd-secrets-manager/issues/28
Ref: #5