Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

fix(*): npm deployment #31

Merged
merged 5 commits into from Feb 26, 2021
Merged

fix(*): npm deployment #31

merged 5 commits into from Feb 26, 2021

Conversation

didinele
Copy link
Contributor

@didinele didinele commented Feb 25, 2021

This PR replaces npmignores for files arrays in each package.json.

Closes #21

@zaida04
Copy link
Member

zaida04 commented Feb 25, 2021

Couldn’t this also be solved by using the files array in each packages package.json? This way we will have a guarantee on what files are distributed.

@didinele
Copy link
Contributor Author

Yeah, I should've probably gone off and taken that approach long ago, good call.

@didinele didinele changed the title fix(*): npm ignores fix(*): npm deployment Feb 26, 2021
zaida04
zaida04 previously approved these changes Feb 26, 2021
@didinele didinele merged commit c4d93ac into main Feb 26, 2021
@didinele didinele deleted the fix/npm-deploy branch February 26, 2021 12:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove source maps from NPM publishes
2 participants