fix(sql): query list type of size 0 (#92)

cordiverse · May 4, 2024 · 538b748 · 538b748
1 parent 06d6562
commit 538b748
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/packages/postgres/src/builder.ts b/packages/postgres/src/builder.ts
@@ -35,10 +35,10 @@ export class PostgresBuilder extends Builder {
       $regex: (key, value) => this.createRegExpQuery(key, value),
       $regexFor: (key, value) => `${this.escape(value)} ~ ${key}`,
       $size: (key, value) => {
-        if (!value) return this.logicalNot(key)
         if (this.isJsonQuery(key)) {
           return `${this.jsonLength(key)} = ${this.escape(value)}`
         } else {
+          if (!value) return `COALESCE(ARRAY_LENGTH(${key}, 1), 0) = 0`
           return `${key} IS NOT NULL AND ARRAY_LENGTH(${key}, 1) = ${value}`
         }
       },

diff --git a/packages/sql-utils/src/index.ts b/packages/sql-utils/src/index.ts
@@ -110,10 +110,10 @@ export class Builder {
         }
       },
       $size: (key, value) => {
-        if (!value) return this.logicalNot(key)
         if (this.isJsonQuery(key)) {
           return `${this.jsonLength(key)} = ${this.escape(value)}`
         } else {
+          if (!value) return this.logicalNot(key)
           return `${key} AND LENGTH(${key}) - LENGTH(REPLACE(${key}, ${this.escape(',')}, ${this.escape('')})) = ${this.escape(value)} - 1`
         }
       },

diff --git a/packages/tests/src/json.ts b/packages/tests/src/json.ts
@@ -98,6 +98,12 @@ namespace JsonTests {
         { size: 3 },
         { size: 3 },
       ])
+
+      await expect(database.select('baz', {
+        nums: { $size: 0 },
+      }).project({
+        size: row => $.length(row.nums),
+      }).execute()).to.eventually.have.length(0)
     })
 
     it('$el', async () => {

diff --git a/packages/tests/src/query.ts b/packages/tests/src/query.ts
@@ -291,6 +291,10 @@ namespace QueryOperators {
       await expect(database.get('temp1', {
         list: { $size: 1 },
       })).eventually.to.have.length(2).with.shape([{ id: 2 }, { id: 3 }])
+
+      await expect(database.get('temp1', {
+        list: { $size: 0 },
+      })).eventually.to.have.length(1).with.shape([{ id: 1 }])
     })
 
     size && it('$.length', async () => {