Use a plugin hook to download the webrtc library

[oNaiPs]

Installing the plugin takes a while as the history of the webrtc library is kept on git, and it significantly increases the size of the initial plugin download. Would it make more sense to download the library before installing?

See
https://github.com/remotium/cordova-plugin-webrtc/blob/master/plugin.xml
https://github.com/remotium/cordova-plugin-webrtc/blob/master/scripts/pull_webrtc_library.js

[ibc]

Interesting. However the "libwertc.so" included in the project is the static library of a customized version of the webrtc library. This is because the original Obj-C code lacks support for MediaStream events and I added it but it's not included in the upstream project:

https://webrtc-codereview.appspot.com/50109004/

Anyhow I will come back to this proposal once I come back from holidays ;)

[YasserRabee]

+1

I suggest to add the hook at pre_build

[ibc]

I'll need some time before I can handle this issue. Please, patience.

[murillo128]

PR are welcome!! ;)

[yocontra]

Got it all working but there is some custom code apparently in the version of WebRTC that this library uses that isn't in WebRTC upstream so it isn't able to build (missing RTCMediaStreamDelegate which was added by @ibc). Tried removing the pointers to this custom code to get it to build and hit more problems, so I'm going to try to figure out what @ibc added to this custom version of WebRTC so I can replicate it

https://github.com/contra/cordova-plugin-iosrtc

[ibc]

We modified the Google's WebRTC ObjC code in order to implement and fix the missing "addtrack" and "removetrack" events of RTCMediaStream. The patch was proposed but Google did not accept it because the WebRTC spec is removing MediaStream tracks events:

https://webrtc-codereview.appspot.com/50109004/

[yocontra]

@ibc is that required for iosrtc to function or is it an enhancement?

[ibc]

Please read the comments in the patch above. It fixes the MediaStream behavior so it is not just an enhancement.

[oNaiPs]

I would suggest as an intermediate solution, to use git LFS for the large file. The repository is getting really slow to clone...

[saghul]

If you are cloning via git you can use --depth 1 to avoid getting the entire history. We now patch libWebRTC even more, so we can't use a generic build.

[oNaiPs]

@saghul that doesn't invalidate what I'm suggesting. Github itself warns about files bigger than 50MB. Did you see how git LFS works? This is sponsored by github.

https://git-lfs.github.com/

[saghul]

I'm aware of LFS. This is not my project, but if it were, I wouldn't use LFS until it's absolutely needed. See the drawbacks here: https://medium.com/@megastep/github-s-large-file-storage-is-no-panacea-for-open-source-quite-the-opposite-12c0e16a9a91#.85wtfitph

I would have already run into the problem of not being able to PR the file stored on LFS (the current build was contributed by me in a PR).

[oNaiPs]

@saghul you're right, it doesn't look like we should use it here.