Upgrade to Swift 3 #221

marcelgoya · 2016-10-29T00:10:41Z

No description provided.

saghul · 2016-10-31T01:55:21Z

Thanks for working on this! I'm on vacation at the moment, but I'll check
it once I'm back.

Saúl

On Oct 29, 2016 07:10, "Marcel Goya" notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

#221
Commit Summary

Upgrade to Swift 3

File Changes

M src/PluginEnumerateDevices.swift
https://github.com/eface2face/cordova-plugin-iosrtc/pull/221/files#diff-0
(14)

M src/PluginGetUserMedia.swift
https://github.com/eface2face/cordova-plugin-iosrtc/pull/221/files#diff-1
(76)

M src/PluginMediaStream.swift
https://github.com/eface2face/cordova-plugin-iosrtc/pull/221/files#diff-2
(180)

M src/PluginMediaStreamRenderer.swift
https://github.com/eface2face/cordova-plugin-iosrtc/pull/221/files#diff-3
(85)

M src/PluginMediaStreamTrack.swift
https://github.com/eface2face/cordova-plugin-iosrtc/pull/221/files#diff-4
(18)

M src/PluginRTCDTMFSender.swift
https://github.com/eface2face/cordova-plugin-iosrtc/pull/221/files#diff-5
(10)

M src/PluginRTCDataChannel.swift
https://github.com/eface2face/cordova-plugin-iosrtc/pull/221/files#diff-6
(78)

M src/PluginRTCPeerConnection.swift
https://github.com/eface2face/cordova-plugin-iosrtc/pull/221/files#diff-7
(1226)

M src/PluginRTCPeerConnectionConfig.swift
https://github.com/eface2face/cordova-plugin-iosrtc/pull/221/files#diff-8
(10)

M src/PluginRTCPeerConnectionConstraints.swift
https://github.com/eface2face/cordova-plugin-iosrtc/pull/221/files#diff-9
(4)

M src/iosrtcPlugin.swift
https://github.com/eface2face/cordova-plugin-iosrtc/pull/221/files#diff-10
(360)

Patch Links:

https://github.com/eface2face/cordova-plugin-iosrtc/pull/221.patch

https://github.com/eface2face/cordova-plugin-iosrtc/pull/221.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#221, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATYGHQQOwBX8FV2-avlyWF0O-l66c2eks5q4o8BgaJpZM4Kj9_9
.

stormbkk87 · 2016-10-31T13:42:00Z

@marcelgoya I'm getting the error below after merging your changes and trying to create a RTCPeerConnection. Any ideas? Seems simple like it's not exposing the plugin functions. However, I'm seeing the onReset write to the log. I'm sure I'm having a brain freeze but cannot for the life of me figure it out with Swift 3.

iosrtcPlugin#onReset() | doing nothing
ERROR: Method 'new_RTCPeerConnection:' not defined in Plugin 'iosrtcPlugin'

marcelgoya · 2016-10-31T15:07:01Z

@stormbkk87 You're right. I'm getting the same error. No idea where this is coming from.

stormbkk87 · 2016-10-31T16:44:17Z

I've been testing other cordova plugins that use audio and worked before I upgraded to Swift 3 and a few don't work anymore. So, looks like Swift 3 changes things. Apple is really annoying me lately. lol

marcelgoya · 2016-10-31T16:47:51Z

You're absolutely not alone! What really pisses me off is that it's impossible to compile Frameworks who run V3 and V2x all together. I mean, they have I dunno how many thousands of devs working for them and they can't even add some shitty compatibility mode?!

marcelgoya · 2016-10-31T16:52:59Z

I'm currently working on a cross platform app which uses WebRTC for the video chat feature and honestly, the amount of time I had wasted just to work around Apple's shit is seriously getting me to the point where I'm considering to stop supporting their platform because it requires such a vast amount of time to fix all their incompatibility problems and to create workarounds. I'm not saying that Android & co are much better, they have their problems too but the level of arrogance coming from Apple is really winding me up.

stormbkk87 · 2016-11-01T18:15:35Z

Aha! Found it. The signature of the CDVPlugin methods are just a bit off so Cordova throws that error. Common cordova error I guess when Apple decides to do the evil signature change of functions. Argh.

I haven't made audio work yet. But I'm getting candidates. @marcelgoya Let me know if audio works for you.

Public cordova function signatures should look like this:

open func new_RTCPeerConnection(_ command: CDVInvokedUrlCommand)

stormbkk87 · 2016-11-01T19:13:16Z

Confirmed audio works on device iPhone 6 iOS 10. Back in the saddle. By the way, whiskey works wonders when dealing with stupid Apple changes. :)

Also, I'm using Meteor 1.4.2 for those having issues upgrading.

marcelgoya · 2016-11-03T03:28:30Z

@stormbkk87 Yup, works for me too

ostrichegret · 2016-11-03T03:52:00Z

btw, can i use this for Sinch SDK?
https://github.com/sinch/sinch-js-rtc

Thanks

marcelgoya · 2016-11-21T14:00:27Z

When are you planning to merge the Swift 3 upgrade into the main branch? It's been almost a month now and I'd like to use the official branch rather than my own.

ibc · 2016-11-21T14:45:42Z

When are you planning to merge the Swift 3 upgrade into the main branch? It's been almost a month now and I'd like to use the official branch rather than my own.

Both @saghul and me have been busy in some conference events lately.

saghul · 2016-11-21T17:10:33Z

@marcelgoya I'm back! Since I merged the getStats PR today this no longer applies cleanly. Can you please rebase it? Thanks!

marcelgoya · 2016-11-22T22:03:45Z

@saghul Sure, but I won't be able to do it before Friday. Cheers

saghul · 2016-11-23T08:56:32Z

@marcelgoya No problem at all, thanks!

marcelgoya · 2016-11-25T19:45:06Z

@saghul I've just updated the PluginRTCPeerConnection file. I noticed a couple of things:

the following delegates were missing:
func peerConnection(onRenegotiationNeeded peerConnection: RTCPeerConnection!)
func peerConnection(_ peerConnection: RTCPeerConnection!, didGetStats stats: [Any]!)
func peerConnection(peerConnection: RTCPeerConnection!,
didGetStats stats: [AnyObject]!) {
needs to be rewritten. You're generating an NSDictionary although an NSArray is required in self.onGetStatsCallback. Also the type casting in the for loop is incorrect.

marcelgoya · 2016-12-01T14:13:33Z

@saghul Any updates on this one?

ibc · 2016-12-01T14:39:01Z

Holidays :)

marcelgoya · 2016-12-01T15:48:09Z

Yeah, me too now :)

saghul · 2016-12-02T09:09:55Z

So, why did you close this?

janowsiany · 2016-12-09T09:44:39Z

Hi, wanted to ask about the status on merging this into master and releasing next version to npm.

saghul · 2016-12-09T10:01:59Z

It will be ready when it's ready, not sooner and not later.

ibc · 2016-12-09T10:02:06Z

Hi, wanted to ask about the status on merging this into master and releasing next version to npm.

Please, don't disturb into the issue just to make us hurry up.

saghul · 2017-03-25T16:31:16Z

I tried to use this PR, but the change is too invasive and didn't work, so I switched to using the syntax converter and fixing all errors. Did some light testing (GUM only) and things seem to work.

Please see #263

Upgrade to Swift 3

b3b1aef

saghul mentioned this pull request Nov 14, 2016

Swift 3 updates. Merge friendly. #229

Closed

Marcel Goya added 2 commits November 25, 2016 14:31

Update

9aa11f9

Update

c101421

marcelgoya closed this Dec 1, 2016

saghul reopened this Dec 5, 2016

saghul mentioned this pull request Feb 6, 2017

Compilation fails with Swift 3 #182

Closed

saghul closed this Mar 25, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Swift 3 #221

Upgrade to Swift 3 #221

marcelgoya commented Oct 29, 2016

saghul commented Oct 31, 2016

stormbkk87 commented Oct 31, 2016

marcelgoya commented Oct 31, 2016

stormbkk87 commented Oct 31, 2016

marcelgoya commented Oct 31, 2016

marcelgoya commented Oct 31, 2016

stormbkk87 commented Nov 1, 2016

stormbkk87 commented Nov 1, 2016 •

edited

marcelgoya commented Nov 3, 2016

ostrichegret commented Nov 3, 2016

marcelgoya commented Nov 21, 2016

ibc commented Nov 21, 2016

saghul commented Nov 21, 2016

marcelgoya commented Nov 22, 2016

saghul commented Nov 23, 2016

marcelgoya commented Nov 25, 2016

marcelgoya commented Dec 1, 2016

ibc commented Dec 1, 2016

marcelgoya commented Dec 1, 2016

saghul commented Dec 2, 2016

janowsiany commented Dec 9, 2016

saghul commented Dec 9, 2016 •

edited by ibc

ibc commented Dec 9, 2016

saghul commented Mar 25, 2017

Upgrade to Swift 3 #221

Upgrade to Swift 3 #221

Conversation

marcelgoya commented Oct 29, 2016

saghul commented Oct 31, 2016

stormbkk87 commented Oct 31, 2016

marcelgoya commented Oct 31, 2016

stormbkk87 commented Oct 31, 2016

marcelgoya commented Oct 31, 2016

marcelgoya commented Oct 31, 2016

stormbkk87 commented Nov 1, 2016

stormbkk87 commented Nov 1, 2016 • edited

marcelgoya commented Nov 3, 2016

ostrichegret commented Nov 3, 2016

marcelgoya commented Nov 21, 2016

ibc commented Nov 21, 2016

saghul commented Nov 21, 2016

marcelgoya commented Nov 22, 2016

saghul commented Nov 23, 2016

marcelgoya commented Nov 25, 2016

marcelgoya commented Dec 1, 2016

ibc commented Dec 1, 2016

marcelgoya commented Dec 1, 2016

saghul commented Dec 2, 2016

janowsiany commented Dec 9, 2016

saghul commented Dec 9, 2016 • edited by ibc

ibc commented Dec 9, 2016

saghul commented Mar 25, 2017

stormbkk87 commented Nov 1, 2016 •

edited

saghul commented Dec 9, 2016 •

edited by ibc