Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12008 : autosave by default proposal for cordova@7 #61

Merged
merged 2 commits into from
Jul 21, 2017

Conversation

audreyso
Copy link
Contributor

Proposal: Autosave will be the default option (when saving or removing dependencies) instead of using the --save flag.

@stevengill
Copy link
Contributor

I like the idea of switching to save by default for cordova@7

@kerrishotts
Copy link

+1 to auto save for cordova@7. I'm consistently forgetting to add it to my cli commands even when I know about it. ;-)

@remcohaszing
Copy link

Using --save screws up the layout of config.xml. Comments are removed, indentation is weird, blank lines are removed. I purposely don't use it.

As long as --save doesn't respect the existing config.xml, I vote against this.

@stevengill
Copy link
Contributor

Interesting point @remcohaszing.

What type of information are you storing in the comments?

How is indentation weird? This is something we might be able to fix when we write out to config.xml.

Most likely, we will take a similar stance to package.json and not have comments in config.xml.

@audreyso
Copy link
Contributor Author

audreyso commented Jan 25, 2017

FYI the proposal has been updated --> Autosave will only be used in the cli right now (not cordova-lib).... you will still need to use the --save flag if using cordova-lib directly.

@brodybits
Copy link

I raised a couple followup issues:

  • Apache CB-12397 - add .gitignore to standard app template
  • Apache CB-12398 - update users guide to document which application artifacts to include/exclude from git

Thanks @audreyso for your work to add the autosave by default.

@audreyso
Copy link
Contributor Author

Thank you for creating these issues! @brodybits

@remcohaszing
Copy link

@stevengill
Comments could be about anything. From my experience they're mainly about why certain versions are locked down. I am totally pro #53 though, which may seem ironic.

I just tried the --save flag again and the indentation isn't as bad as I remember.

@stevengill stevengill merged commit 720ccad into apache:master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants