feat(alpine-node-nginx): add slim versions #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6b21b31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
IH8E
approved these changes
Mar 27, 2024
Echzio
approved these changes
Mar 27, 2024
.github/workflows/alpine-node.yml
Outdated
| { node: 20.11.1, alpine: 3.19, image: node, dockerfile: Dockerfile, tag: 20.11.1 }, | ||
|
|
||
| { node: 16.20.2, alpine: 3.18, image: node, dockerfile: Dockerfile-slim, tag: 16.20.2-slim }, | ||
| { node: 18.19.1, alpine: 3.19, image: node, dockerfile: Dockerfile-slim, tag: 18.19.1-slim }, |
There was a problem hiding this comment.
лучше сразу 18.20.0, чтобы реже обновлять
packages/alpine-node-nginx/README.md
Outdated
|
|
||
| Список доступных версий образа: | ||
| - 16.20.2, 16.20.2-slim | ||
| - 18.19.1, 18.19.1-slim |
packages/alpine-node-nginx/README.md
Outdated
|
|
||
| ### Локальная сборка контейнера | ||
| Если вы хотите собрать локально, выполните | ||
|
|
||
| ```sh | ||
| docker build --build-arg NODE_VERSION=14.17.6 --build-arg ALPINE_VERSION=3.16 -t alfabankui/arui-scripts:14.17.6 . | ||
| docker build --build-arg NODE_VERSION=18.19.0 --build-arg ALPINE_VERSION=3.19 -t alfabankui/arui-scripts:14.17.6 . |
| ``` | ||
|
|
||
| ### Локальная сборка на arm-процессорах | ||
| Если у вас ноутбук на M1 - по умолчанию docker build будет собирать контейнер именно под arm архитектуру, и запустить | ||
| его на наших серверах будет невозможно. Поэтому собирать нужно немного иначе: | ||
|
|
||
| ```sh | ||
| docker buildx build --platform linux/amd64 --build-arg NODE_VERSION=16.20.2 --build-arg ALPINE_VERSION=3.18 -t alfabankui/arui-scripts:test --load . | ||
| docker buildx build --platform linux/amd64 --build-arg NODE_VERSION=18.19.0 --build-arg ALPINE_VERSION=3.19 -t alfabankui/arui-scripts:test -f Dockerfile-slim --load . |
There was a problem hiding this comment.
лучше привести к одной везде версии NODE_VERSION=18.20.0
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлена "компактная" версия базового докер-образа.
За счет отказа от нескольких лишних модулей nginx удалось убрать около 50 бинарных зависимостей ну и плюсом срезать размер образа - 136 мб против 160.
Из базового так же удалены совсем уж лишние модули nginx - webdav, стриминг flv и прочее.
Тег для новых образов будет с постфиксом
-slim, так что обновляться на него нужно будет осознано. Часть проектов все же используют ssl модули, поэтому ломать им их работающую сборку не хочется.