feat(select): dont highlight first option on open

core-ds · Jul 9, 2021 · 015a084 · 015a084
1 parent 3bfbe70
commit 015a084
Show file tree

Hide file tree

Showing 11 changed files with 21 additions and 21 deletions.
diff --git a/...picker-button/src/__image_snapshots__/picker-button-test-positioning-2-snap.png b/...picker-button/src/__image_snapshots__/picker-button-test-positioning-2-snap.png
diff --git a/...picker-button/src/__image_snapshots__/picker-button-test-positioning-3-snap.png b/...picker-button/src/__image_snapshots__/picker-button-test-positioning-3-snap.png
diff --git a/...s/picker-button/src/__image_snapshots__/picker-button-test-positioning-snap.png b/...s/picker-button/src/__image_snapshots__/picker-button-test-positioning-snap.png
diff --git a/packages/select/src/Component.test.tsx b/packages/select/src/Component.test.tsx
@@ -291,7 +291,7 @@ describe('Select', () => {
             const input = document.querySelector('.input') as HTMLElement;
             await pressArrowDownNTimes(input, options.length + 1);
             expect((document.querySelector('.highlighted div') as HTMLElement).innerHTML).toBe(
-                options[1].content,
+                options[0].content,
             );
         });
 
@@ -425,7 +425,7 @@ describe('Select', () => {
             const expectedProps: Partial<OptionsListProps> = {
                 options,
                 flatOptions: options,
-                highlightedIndex: 0,
+                highlightedIndex: -1,
                 open: true,
                 size: 'l',
                 visibleOptions: 3,

diff --git a/...pshots__/select-interactions-tests-click-open-select-select-one-item-2-snap.png b/...pshots__/select-interactions-tests-click-open-select-select-one-item-2-snap.png
diff --git a/...hots__/select-interactions-tests-default-open-select-select-one-item-2-snap.png b/...hots__/select-interactions-tests-default-open-select-select-one-item-2-snap.png
diff --git a/.../select/src/__image_snapshots__/select-interactions-tests-long-options-snap.png b/.../select/src/__image_snapshots__/select-interactions-tests-long-options-snap.png
diff --git a/...lect/src/__image_snapshots__/select-interactions-tests-visible-options-snap.png b/...lect/src/__image_snapshots__/select-interactions-tests-visible-options-snap.png
diff --git a/packages/select/src/__image_snapshots__/select-optgroup-click-snap.png b/packages/select/src/__image_snapshots__/select-optgroup-click-snap.png
diff --git a/packages/select/src/__image_snapshots__/select-optgroup-default-snap.png b/packages/select/src/__image_snapshots__/select-optgroup-default-snap.png
diff --git a/packages/select/src/components/base-select/Component.tsx b/packages/select/src/components/base-select/Component.tsx
@@ -140,7 +140,7 @@ export const BaseSelect = forwardRef(
             circularNavigation,
             items: flatOptions,
             itemToString,
-            defaultHighlightedIndex: selectedItems.length === 0 ? 0 : undefined,
+            defaultHighlightedIndex: selectedItems.length === 0 ? -1 : undefined,
             onIsOpenChange: changes => {
                 if (onOpen) {
                     onOpen({