fix(inputs): remove from state, detect by value prop

core-ds · Mar 4, 2020 · 208c07e · 208c07e
1 parent e0abeba
commit 208c07e
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/packages/base-input/src/Component.tsx b/packages/base-input/src/Component.tsx
@@ -78,8 +78,8 @@ export const BaseInput = React.forwardRef<HTMLInputElement, BaseInputProps>(({
     dataTestId
 }, ref) => {
     const [focused, setFocused] = useState(false);
-    const [filled, setFilled] = useState(!!value);
 
+    const filled = !!value;
     const hasLabel = !!label;
 
     function handleInputFocus(e: React.FocusEvent<HTMLInputElement>) {
@@ -99,8 +99,6 @@ export const BaseInput = React.forwardRef<HTMLInputElement, BaseInputProps>(({
     }
 
     function handleInputChange(e: React.ChangeEvent<HTMLInputElement>) {
-        setFilled(!!e.target.value);
-
         if (onChange) {
             onChange(e);
         }