fix(calendar-input): call onchange with empty value

core-ds · Apr 9, 2021 · 3fbc73a · 3fbc73a
1 parent 744250a
commit 3fbc73a
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/packages/calendar-input/src/Component.test.tsx b/packages/calendar-input/src/Component.test.tsx
@@ -441,6 +441,25 @@ describe('CalendarInput', () => {
 
             expect(cb).toBeCalledTimes(1);
         });
+
+        it('should call onChange if empty date is entered', async () => {
+            const cb = jest.fn();
+            const { queryByRole } = render(
+                <CalendarInput calendarPosition='static' defaultValue='1' onChange={cb} />,
+            );
+
+            const input = queryByRole('textbox') as HTMLInputElement;
+
+            input.setSelectionRange(0, 2);
+            await userEvent.type(input, '{backspace}');
+
+            expect(cb).toBeCalledTimes(1);
+
+            const { date, value } = cb.mock.calls[0][1];
+
+            expect(value).toBe('');
+            expect((date as Date).getTime()).toBeNaN();
+        });
     });
 
     describe('Render tests', () => {

diff --git a/packages/calendar-input/src/Component.tsx b/packages/calendar-input/src/Component.tsx
@@ -244,7 +244,13 @@ export const CalendarInput = forwardRef<HTMLInputElement, CalendarInputProps>(
                 const newValue = event.target.value;
                 const newDate = parseDateString(newValue);
 
-                changeHandler(event, newValue, newDate, 'input', isCompleteDateInput(newValue));
+                changeHandler(
+                    event,
+                    newValue,
+                    newDate,
+                    'input',
+                    !newValue || isCompleteDateInput(newValue),
+                );
             },
             [changeHandler],
         );