Skip to content

Commit

Permalink
fix(calendar): fixes (#498)
Browse files Browse the repository at this point in the history
* fix(calendar): selected & disabled style

* fix(calendar): limit only years if minDate is not specified

* fix(calendar-range): fix story

* feat(themes): add calendar-input click theme
  • Loading branch information
reme3d2y committed Feb 8, 2021
1 parent c12646d commit 410630e
Show file tree
Hide file tree
Showing 7 changed files with 34 additions and 27 deletions.
13 changes: 7 additions & 6 deletions packages/calendar-range/src/Component.stories.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,11 @@ import { CalendarRange } from '@alfalab/core-components-calendar-range';

<Preview>
{React.createElement(() => {
const [valueFrom, setValueFrom] = React.useState('10.11.2020');
const [valueTo, setValueTo] = React.useState('20.11.2020');
const minDate = subMonths(startOfDay(new Date()), 2).getTime();
const maxDate = addMonths(startOfDay(new Date()), 2).getTime();
const defaultDate = '10.11.2020';
const [valueFrom, setValueFrom] = React.useState(defaultDate);
const [valueTo, setValueTo] = React.useState('');
const minDate = subMonths(startOfDay(parseDateString(defaultDate)), 2).getTime();
const maxDate = addMonths(startOfDay(parseDateString(defaultDate)), 2).getTime();
const [fromError, setFromError] = React.useState('');
const [toError, setToError] = React.useState('');
const valid = (value) => {
Expand All @@ -87,8 +88,8 @@ import { CalendarRange } from '@alfalab/core-components-calendar-range';
const handleToFocus = () => setToError('');
return (
<CalendarRange
minDate={subMonths(startOfDay(new Date()), 2).getTime()}
maxDate={addMonths(startOfDay(new Date()), 2).getTime()}
minDate={minDate}
maxDate={maxDate}
valueFrom={valueFrom}
valueTo={valueTo}
onDateFromChange={({ value }) => {
Expand Down
9 changes: 4 additions & 5 deletions packages/calendar/src/Component.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { forwardRef, useCallback, useMemo, useState } from 'react';
import cn from 'classnames';
import { startOfMonth, subYears } from 'date-fns';
import { startOfMonth } from 'date-fns';
import { Header } from './components/header';
import { DaysTable } from './components/days-table';
import { MonthsTable } from './components/months-table';
Expand Down Expand Up @@ -121,10 +121,9 @@ export const Calendar = forwardRef<HTMLDivElement, CalendarProps>(
monthTimestamp,
]);

const minDate = useMemo(
() => (minDateTimestamp ? new Date(minDateTimestamp) : subYears(defaultMonth, 100)),
[minDateTimestamp, defaultMonth],
);
const minDate = useMemo(() => (minDateTimestamp ? new Date(minDateTimestamp) : undefined), [
minDateTimestamp,
]);

const maxDate = useMemo(() => (maxDateTimestamp ? new Date(maxDateTimestamp) : undefined), [
maxDateTimestamp,
Expand Down
12 changes: 0 additions & 12 deletions packages/calendar/src/__snapshots__/Component.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -2057,18 +2057,6 @@ exports[`Calendar Display tests should match defaultView="years" snapshot 1`] =
1921
</span>
</button>
<button
aria-selected="false"
class="component ghost xs button default button"
data-date="-1577923200000"
tabindex="-1"
>
<span
class="text stretchText"
>
1920
</span>
</button>
</div>
</div>
</div>
Expand Down
3 changes: 2 additions & 1 deletion packages/calendar/src/components/days-table/index.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@
border-radius: 0;
}

&.selected {
&.selected,
&.disabled.selected {
color: var(--calendar-selected-color);
background: var(--calendar-selected-background);
cursor: default;
Expand Down
17 changes: 14 additions & 3 deletions packages/calendar/src/useCalendar.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
import { KeyboardEvent, MouseEvent, Ref, useCallback, useMemo, useRef, useState } from 'react';
import { startOfMonth, isSameDay, isSameMonth, isSameYear, setYear, addMonths } from 'date-fns';
import {
startOfMonth,
isSameDay,
isSameMonth,
isSameYear,
setYear,
addMonths,
subYears,
} from 'date-fns';
import mergeRefs from 'react-merge-refs';
import {
limitDate,
Expand Down Expand Up @@ -32,7 +40,7 @@ export type UseCalendarProps = {
/**
* Минимальная дата, доступная для выбора
*/
minDate: Date;
minDate?: Date;

/**
* Максимальная дата, доступная для выбора
Expand Down Expand Up @@ -108,7 +116,10 @@ export function useCalendar({
activeMonth,
]);

const years = useMemo(() => generateYears(minDate, maxDate || new Date()), [minDate, maxDate]);
const years = useMemo(
() => generateYears(minDate || subYears(new Date(), 100), maxDate || new Date()),
[minDate, maxDate],
);

const setMonth = useCallback(
(newMonth: Date) => {
Expand Down
5 changes: 5 additions & 0 deletions packages/themes/src/mixins/calendar-input/click.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
@import '../../../../vars/src/index.css';

@define-mixin calendar-input-click {
--calendar-input-calendar-icon: url('https://alfabank.st/icons/glyph_calendar_m.svg');
}
2 changes: 2 additions & 0 deletions packages/themes/src/mixins/click.css
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
@import './select/click.css';
@import './confirmation/click.css';
@import './calendar/click.css';
@import './calendar-input/click.css';
@import './toast-plate/click.css';

@define-mixin theme-click {
Expand All @@ -30,5 +31,6 @@
@mixin select-click;
@mixin confirmation-click;
@mixin calendar-click;
@mixin calendar-input-click;
@mixin toast-plate-click;
}

0 comments on commit 410630e

Please sign in to comment.